Skip to content

Commit 5f3de3f

Browse files
committed
cleanup
1 parent fe00ce5 commit 5f3de3f

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

environment_setup/setup_software.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
!/bin/bash
1+
#!/bin/bash
22

33
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
44
# UBC Thunderbots Ubuntu Software Setup

src/starlark/nanopb/nanopb.bzl

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ def _construct_cc_info(
187187
nanopb_linking_contexts,
188188
nanopb_compilation_contexts):
189189
"""
190-
Constructs the CcInfo, the underlying provider for cc_library.
190+
Builder for CcInfo, the underlying provider for cc_library.
191191
192192
Since CcInfo's in a dep tree are compiled incrementally into artifacts and linked during bazel build,
193193
we must construct this build target explicitly so that any cc_library's in our codebase can refer to these
@@ -264,6 +264,16 @@ def _construct_default_info(zip_file):
264264
return DefaultInfo(files = depset([zip_file]))
265265

266266
def _construct_platformio_library_info(ctx, zip_file):
267+
"""
268+
Builder for the PlatformIOLibraryInfo provider.
269+
270+
This is the provider used by platformio_rules so that the generated lib can be used as a dep in platformio_library.
271+
This provider allows for platformio_rules to aggregate dependencies via paths to source files and also allows for
272+
for using other platformio_library's as a dep to this lib. Transitive deps are also collected at this stage.
273+
274+
:param zip_file: Files and deps to include in the library
275+
:return: PlatformIOLibraryInfo with the contents of zip_file
276+
"""
267277
runfiles = ctx.runfiles(files = [zip_file])
268278
transitive_libdeps = []
269279
for dep in ctx.attr.deps:

0 commit comments

Comments
 (0)