Remove all c++ simulated tests

[nycrat]

Description

Gets rid of all er force simulated tests written in c++, and all the code that relates to it such as validation functions.

Testing Done

Resolved Issues

resolves #2581, resolves #2510

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

• Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
• Remove all commented out code
• Remove extra print statements: for example, those just used for testing
• Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

[Andrewyx]

@williamckha Can you verify this is a safe action now?

[williamckha]

@williamckha Can you verify this is a safe action now?

Not sure, I haven't been keeping up to date with the status of porting our sim tests. I would assume Eric and team have a better idea of what's left to be ported (which by the look of things, seems like none)

[nycrat]

@williamckha Can you verify this is a safe action now?

Not sure, I haven't been keeping up to date with the status of porting our sim tests. I would assume Eric and team have a better idea of what's left to be ported (which by the look of things, seems like none)

Changes to port rest of the c++ tests are in #3632

[adrianchan787]

Looks great, approved because this is likely either planned or a mistake on my end but was wondering
I think (maybe I switched branches badly?) you still have e.g. kickoff_friendly_play_test.py, so is there a reason for deleting that pytest target from the build file?

[nycrat]

Looks great, approved because this is likely either planned or a mistake on my end but was wondering
I think (maybe I switched branches badly?) you still have e.g. kickoff_friendly_play_test.py, so is there a reason for deleting that pytest target from the build file?

@adrianchan787 GOOD CATCH

I think it was a git merge conflict issue where all the new py_test targets were removed, I'll add back all of them into the build files.

[Andrewyx]

LGTM! 🚀

[adrianchan787]

Looks great!