Skip to content

Use er force simulator position data for pytest validations#3699

Closed
StarrryNight wants to merge 5 commits into
UBC-Thunderbots:masterfrom
StarrryNight:use_true_locations
Closed

Use er force simulator position data for pytest validations#3699
StarrryNight wants to merge 5 commits into
UBC-Thunderbots:masterfrom
StarrryNight:use_true_locations

Conversation

@StarrryNight
Copy link
Copy Markdown
Contributor

Description

Resolves:
#3684

Previously, our validations checks the ball/robot locations with the sensor fused data. That is not ideal, because we should be testing against the ground truth, which is the positional data generated directly from the er-force simulator.

This ticket accomplishes this by passing in a simulator state in validations and using its locations. When nothing is passed, validation falls back to using sensor fused data.

Testing Done

Works locally.

Resolved Issues

#3684

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@StarrryNight StarrryNight changed the title Use er force simulator positions for pytest validations Use er force simulator position data for pytest validations May 15, 2026
@nycrat
Copy link
Copy Markdown
Member

nycrat commented May 15, 2026

@StarrryNight is this PR ready for review? It seems like the simulator states being passed into the validation functions are not used at all. Perhaps I'm misunderstanding the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants