Use er force simulator position data for pytest validations#3699
Closed
StarrryNight wants to merge 5 commits into
Closed
Use er force simulator position data for pytest validations#3699StarrryNight wants to merge 5 commits into
StarrryNight wants to merge 5 commits into
Conversation
8b88b87 to
815f028
Compare
4 tasks
Member
|
@StarrryNight is this PR ready for review? It seems like the simulator states being passed into the validation functions are not used at all. Perhaps I'm misunderstanding the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves:
#3684
Previously, our validations checks the ball/robot locations with the sensor fused data. That is not ideal, because we should be testing against the ground truth, which is the positional data generated directly from the er-force simulator.
This ticket accomplishes this by passing in a simulator state in validations and using its locations. When nothing is passed, validation falls back to using sensor fused data.
Testing Done
Works locally.
Resolved Issues
#3684
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue