Skip to content

Clean up robot constants and enable compile-time selection#3714

Merged
Andrewyx merged 1 commit into
masterfrom
tbots/robot_constants
May 19, 2026
Merged

Clean up robot constants and enable compile-time selection#3714
Andrewyx merged 1 commit into
masterfrom
tbots/robot_constants

Conversation

@williamckha
Copy link
Copy Markdown
Member

@williamckha williamckha commented May 18, 2026

Description

Refactors the robot constants invocation and structure to allow for compile-time selection and static definition.

Testing Done

Thunderscope runs, tests pass, robots work.

Resolved Issues

QOL update

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Andrewyx Andrewyx requested review from a team, AadityaSuri, AmyKawa, GrayHoang, a-png129 and nycrat and removed request for a team, AadityaSuri and AmyKawa May 18, 2026 19:42
Copy link
Copy Markdown
Member

@nycrat nycrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me 👍

Comment thread src/shared/constants.h
Comment thread src/software/thunderscope/thunderscope_main.py
@Andrewyx Andrewyx merged commit e0db5b2 into master May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants