Pass in delta_time dynamically for prim exec#3758
Merged
Merged
Conversation
this is removed even thought is technically used now cause future changes will get rid of it
This was referenced Jun 4, 2026
nycrat
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
williamckha
dismissed
annieisawesome2’s stale review
The base branch was changed.
williamckha
previously approved these changes
Jun 5, 2026
williamckha
approved these changes
Jun 5, 2026
annieisawesome2
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a stacked PR: #3756 #3758 #3759 #3760.
This PR removes the time_step field in PrimitiveExecutor and instead adds an extra delta_time argument to stepPrimitive() so that we allow for a dynamic time step.
Testing Done
Resolved Issues
resolves #2855
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue