Skip to content

Use RobotState instead of individual variables for prim exec#3759

Merged
nycrat merged 12 commits into
masterfrom
avah/prim_exec_update_state
Jun 5, 2026
Merged

Use RobotState instead of individual variables for prim exec#3759
nycrat merged 12 commits into
masterfrom
avah/prim_exec_update_state

Conversation

@nycrat
Copy link
Copy Markdown
Member

@nycrat nycrat commented Jun 4, 2026

Description

This is a stacked PR: #3756 #3758 #3759 #3760.

In ErForceSimulator and PrimitiveExecutor, we originally passed robot velocities and angular velocities as an std::pair or as separate function arguments. Since we will need the robot position and orientations as well for the updated primitive executor, this data should be encapsulated into a RobotState struct. However, since there is already a RobotState class, I just reused this class and added setters since originally it was read-only.

Also see: #3716 (comment)

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat marked this pull request as ready for review June 4, 2026 22:20
@nycrat nycrat requested review from StarrryNight and a-png129 June 4, 2026 22:34
@nycrat nycrat changed the base branch from avah/prim_exec_dynamic_time_step to master June 5, 2026 02:00
@nycrat nycrat merged commit 2047239 into master Jun 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants