Purpose
Now that we have the wind tracking over 30 seconds feature implemented. We have to add this check to must_change method. You will have to look out for cases where is_significant_change returns None.
Once you have done that, come up with Tests that check if the path in fact has changed. This part is quite hard. So before you start doing this, have a discussion with @AMaharaj16, @SPDonaghy, or @raghumanimehta (me). I would suggest using Mocks for this as they allow us to statically analyze behaviour.
Manually verify that the deque that was added as part of is_significant_change is tracking the data properly. I know @MilcToast has added tests, but it is a good idea to see it running in production to ensure that it is actually accumulating data properly.
Resources
Purpose
Now that we have the wind tracking over 30 seconds feature implemented. We have to add this check to
must_changemethod. You will have to look out for cases whereis_significant_changereturnsNone.Once you have done that, come up with Tests that check if the path in fact has changed. This part is quite hard. So before you start doing this, have a discussion with @AMaharaj16, @SPDonaghy, or @raghumanimehta (me). I would suggest using
Mocksfor this as they allow us to statically analyze behaviour.Manually verify that the deque that was added as part of
is_significant_changeis tracking the data properly. I know @MilcToast has added tests, but it is a good idea to see it running in production to ensure that it is actually accumulating data properly.Resources
sailbot_workspace/src/local_pathfinding/local_pathfinding/local_path.py
Line 290 in 0b35a48
sailbot_workspace/src/local_pathfinding/local_pathfinding/local_path.py
Line 382 in 0b35a48
https://docs.python.org/3/library/unittest.mock.html