228 prevent two strands with the same name#257
Open
mobinano wants to merge 16 commits into
Open
Conversation
Removed _name in Strand Class
dave-doty
requested changes
Apr 16, 2024
| @abstractmethod | ||
| def name(self) -> str: | ||
| pass | ||
| # @property |
Member
There was a problem hiding this comment.
Let's not leave dead comments like this, just delete them.
|
|
||
| _name: str | None = None | ||
| name: str | ||
| """Optional name of strand.""" |
| @@ -2666,7 +2666,7 @@ def name(self) -> str: | |||
| if self._name is None: | |||
| self._name = self.domain_names_concatenated() | |||
| return self._name | |||
Member
There was a problem hiding this comment.
Why are there two return statements one after the other here?
| """ | ||
|
|
||
| _name: str | None = None | ||
| name: str |
Member
There was a problem hiding this comment.
There should be an error since name is being declared after vendor_fields, since non-optional fields need to precede optional fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.