Add optimizations to collision kernel for AMD GPUs#14
Open
gsitaram wants to merge 1 commit into
Open
Conversation
…n GPU_CollideStream_mMidFluidCollision_mWallCollision_sBB_WallShearStress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change block size and use template parameter instead of _NUMVECTORS in
GPU_CollideStream_mMidFluidCollision_mWallCollision_sBB_WallShearStress kernelto improve achieved memory bandwidth in the kernel. The larger block size helps lower TLB misses and the template parameter makes the number of vectors argument a compile time constant that helps the compiler avoid spilling local arrays to slower scratch memory.Please test and accept these changes to significantly improve HemeLB performance on AMD GPUs.