Skip to content

Commit 3a1c022

Browse files
committed
fix: properly call all appendCard events
1 parent 2ed1c07 commit 3a1c022

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

src/base/vanilla/card.append.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,23 @@ internal.on('set', (e = PREFIX) => {
1515
event = e;
1616
}).on('pre', (...args) => {
1717
eventManager.emit(`pre:func:${event}`, ...args);
18+
if (event !== PREFIX) eventManager.emit(`pre:func:${PREFIX}`, ...args);
1819
}).on('post', (...args) => {
1920
if (event === PREFIX || !args.length) {
20-
const eventData = data || args; // If no data then the event was canceled somehow, and we need to clear the event
21+
const eventData = [
22+
...data,
23+
...args,
24+
];
25+
// If no data then the event was canceled somehow, and we need to clear the event
2126
if (eventData.length) {
2227
eventManager.emit(`func:${event}`, ...eventData);
23-
if (event !== PREFIX) eventManager.emit(`func:${PREFIX}`, ...eventData); // Always call func:appendCard?
28+
if (event !== PREFIX) eventManager.emit(`func:${PREFIX}`, ...eventData);
2429
}
2530
data = null;
2631
event = PREFIX; // Reset
2732
} else {
2833
data = args;
2934
if (extras.isSet()) data.push(...extras.value);
30-
eventManager.emit(`func:${PREFIX}`, ...data); // Always call func:appendCard?
3135
}
3236
});
3337

@@ -36,6 +40,7 @@ eventManager.on(':loaded', () => {
3640
internal.emit('pre', card);
3741
const element = this.super(card, container);
3842
if (eventManager.emit(`${PREFIX}()`, { card, element, container }).ran) { // Support old listeners
43+
// eslint-disable-next-line no-console -- Warn developers to not use this
3944
console.warn(`'${PREFIX}()' is deprecated, please use 'func:${PREFIX}' instead`);
4045
}
4146
internal.emit('post', card, element);

0 commit comments

Comments
 (0)