refactor(project): Align getReader API internals with ComponentProjects

Cherry-picked from: SAP/ui5-project@82b20ee
JIRA: CPOUI5FOUNDATION-1174

Author: RandomByte

packages/project/lib/specifications/types/Module.js

@@ -69,25 +69,10 @@ class Module extends Project {
 		// Apply builder excludes to all styles but "runtime"
 		const excludes = style === "runtime" ? [] : this.getBuilderResourcesExcludes();
 
-		const readers = this._paths.map(({name, virBasePath, fsBasePath}) => {
-			return resourceFactory.createReader({
-				name,
-				virBasePath,
-				fsBasePath,
-				project: this,
-				excludes
-			});
-		});
-		if (readers.length === 1) {
-			return readers[0];
-		}
-		const readerCollection = resourceFactory.createReaderCollection({
-			name: `Reader collection for module project ${this.getName()}`,
-			readers
-		});
+		const reader = this._getReader(excludes);
 		return resourceFactory.createReaderCollectionPrioritized({
 			name: `Reader/Writer collection for project ${this.getName()}`,
-			readers: [this._getWriter(), readerCollection]
+			readers: [this._getWriter(), reader]
 		});
 	}
 
@@ -98,7 +83,8 @@ class Module extends Project {
 	 * @returns {@ui5/fs/ReaderCollection} A reader collection instance
 	 */
 	getWorkspace() {
-		const reader = this.getReader();
+		const excludes = this.getBuilderResourcesExcludes();
+		const reader = this._getReader(excludes);
 
 		const writer = this._getWriter();
 		return resourceFactory.createWorkspace({
@@ -107,6 +93,25 @@ class Module extends Project {
 		});
 	}
 
+	_getReader(excludes) {
+		const readers = this._paths.map(({name, virBasePath, fsBasePath}) => {
+			return resourceFactory.createReader({
+				name,
+				virBasePath,
+				fsBasePath,
+				project: this,
+				excludes
+			});
+		});
+		if (readers.length === 1) {
+			return readers[0];
+		}
+		return resourceFactory.createReaderCollection({
+			name: `Reader collection for module project ${this.getName()}`,
+			readers
+		});
+	}
+
 	_getWriter() {
 		if (!this._writer) {
 			this._writer = resourceFactory.createAdapter({

packages/project/lib/specifications/types/ThemeLibrary.js

@@ -76,26 +76,7 @@ class ThemeLibrary extends Project {
 		// Apply builder excludes to all styles but "runtime"
 		const excludes = style === "runtime" ? [] : this.getBuilderResourcesExcludes();
 
-		let reader = resourceFactory.createReader({
-			fsBasePath: this.getSourcePath(),
-			virBasePath: "/resources/",
-			name: `Runtime resources reader for theme-library project ${this.getName()}`,
-			project: this,
-			excludes
-		});
-		if (this._testPathExists) {
-			const testReader = resourceFactory.createReader({
-				fsBasePath: fsPath.join(this.getRootPath(), this._testPath),
-				virBasePath: "/test-resources/",
-				name: `Runtime test-resources reader for theme-library project ${this.getName()}`,
-				project: this,
-				excludes
-			});
-			reader = resourceFactory.createReaderCollection({
-				name: `Reader collection for theme-library project ${this.getName()}`,
-				readers: [reader, testReader]
-			});
-		}
+		const reader = this._getReader(excludes);
 		const writer = this._getWriter();
 
 		return resourceFactory.createReaderCollectionPrioritized({
@@ -115,7 +96,8 @@ class ThemeLibrary extends Project {
 	* @returns {@ui5/fs/DuplexCollection} DuplexCollection
 	*/
 	getWorkspace() {
-		const reader = this.getReader();
+		const excludes = this.getBuilderResourcesExcludes();
+		const reader = this._getReader(excludes);
 
 		const writer = this._getWriter();
 		return resourceFactory.createWorkspace({
@@ -124,6 +106,30 @@ class ThemeLibrary extends Project {
 		});
 	}
 
+	_getReader(excludes) {
+		let reader = resourceFactory.createReader({
+			fsBasePath: this.getSourcePath(),
+			virBasePath: "/resources/",
+			name: `Runtime resources reader for theme-library project ${this.getName()}`,
+			project: this,
+			excludes
+		});
+		if (this._testPathExists) {
+			const testReader = resourceFactory.createReader({
+				fsBasePath: fsPath.join(this.getRootPath(), this._testPath),
+				virBasePath: "/test-resources/",
+				name: `Runtime test-resources reader for theme-library project ${this.getName()}`,
+				project: this,
+				excludes
+			});
+			reader = resourceFactory.createReaderCollection({
+				name: `Reader collection for theme-library project ${this.getName()}`,
+				readers: [reader, testReader]
+			});
+		}
+		return reader;
+	}
+
 	_getWriter() {
 		if (!this._writer) {
 			this._writer = resourceFactory.createAdapter({