refactor(project): Cleanup build cache utils

Remove unused firstTruthy method, drop the stale local ResourceMetadata
typedef (use existing type from HashTree.js), and strip the
UI5_CACHE_PERF instrumentation.

Author: RandomByte

packages/project/lib/build/cache/utils.js

@@ -1,21 +1,3 @@
-/**
- * @typedef {object} ResourceMetadata
- * @property {string} integrity Content integrity of the resource
- * @property {number} lastModified Last modified timestamp (mtimeMs)
- * @property {number} inode Inode number of the resource
- * @property {number} size Size of the resource in bytes
- */
-
-const PERF_TRACKING = !!process.env.UI5_CACHE_PERF;
-const perfCounters = {
-	calls: 0,
-	shortCircuitTrue: 0,
-	sizeMismatch: 0,
-	inodeMismatch: 0,
-	integrityFallback: 0,
-};
-export {perfCounters as isResourceUnchangedCounters};
-
 /**
  * Determines if a resource has changed compared to cached metadata
  *
@@ -25,7 +7,8 @@ export {perfCounters as isResourceUnchangedCounters};
  *
  * @public
  * @param {@ui5/fs/Resource} resource Resource instance to compare
- * @param {ResourceMetadata} cachedMetadata Cached metadata from the tree
+ * @param {@ui5/project/build/cache/index/HashTree~ResourceMetadata} cachedMetadata
+ *   Cached metadata from the tree
  * @param {number} [indexTimestamp] Timestamp when the tree state was created
  * @returns {Promise<boolean>} True if resource content is unchanged
  * @throws {Error} If resource or metadata is undefined
@@ -34,14 +17,12 @@ export async function isResourceUnchanged(resource, cachedMetadata, indexTimesta
 	if (!resource || !cachedMetadata) {
 		throw new Error("Cannot compare undefined resources or metadata");
 	}
-	if (PERF_TRACKING) perfCounters.calls++;
 
 	// Size mismatch indicates a definite content change. Required before any
 	// "unchanged" decision because mtime preservation (cp -p, tar -x, rsync -t,
 	// atomic rename) does not imply content unchanged.
 	const currentSize = await resource.getSize();
 	if (currentSize !== cachedMetadata.size) {
-		if (PERF_TRACKING) perfCounters.sizeMismatch++;
 		return false;
 	}
 
@@ -54,27 +35,23 @@ export async function isResourceUnchanged(resource, cachedMetadata, indexTimesta
 	const inodeMismatch =
 		cachedMetadata.inode !== undefined && currentInode !== undefined &&
 		currentInode !== cachedMetadata.inode;
-	if (inodeMismatch && PERF_TRACKING) perfCounters.inodeMismatch++;
 
 	// mtime + size both match and the file has not been replaced → unchanged,
 	// unless we are in the racy-git window (mtime === indexTimestamp), where
 	// content may have changed during indexing without mtime moving.
 	const currentLastModified = resource.getLastModified();
 	if (!inodeMismatch && currentLastModified === cachedMetadata.lastModified) {
 		if (indexTimestamp && currentLastModified !== indexTimestamp) {
-			if (PERF_TRACKING) perfCounters.shortCircuitTrue++;
 			return true;
 		}
 		// Race condition possible — fall through to integrity check
 	}
 
 	// mtime differs, file was replaced, or racy window — verify content.
-	if (PERF_TRACKING) perfCounters.integrityFallback++;
 	const currentIntegrity = await resource.getIntegrity();
 	return currentIntegrity === cachedMetadata.integrity;
 }
 
-
 /**
  * Creates an index of resource metadata from an array of resources
  *
@@ -98,40 +75,3 @@ export async function createResourceIndex(resources) {
 		};
 	}));
 }
-
-/**
- * Returns the first truthy value from an array of promises
- *
- * This function evaluates all promises in parallel and returns immediately
- * when the first truthy value is found. If all promises resolve to falsy
- * values, null is returned.
- *
- * @param {Promise[]} promises Array of promises to evaluate
- * @returns {Promise<*>} The first truthy resolved value or null if all are falsy
- */
-export async function firstTruthy(promises) {
-	return new Promise((resolve, reject) => {
-		let completed = 0;
-		const total = promises.length;
-
-		if (total === 0) {
-			resolve(null);
-			return;
-		}
-
-		promises.forEach((promise) => {
-			Promise.resolve(promise)
-				.then((value) => {
-					if (value) {
-						resolve(value);
-					} else {
-						completed++;
-						if (completed === total) {
-							resolve(null);
-						}
-					}
-				})
-				.catch(reject);
-		});
-	});
-}

packages/project/test/lib/build/cache/utils.js

@@ -1,8 +1,7 @@
 import test from "ava";
 import {
 	isResourceUnchanged,
-	createResourceIndex,
-	firstTruthy
+	createResourceIndex
 } from "../../../../lib/build/cache/utils.js";
 
 function createMockResource(opts = {}) {
@@ -163,44 +162,3 @@ test("createResourceIndex: empty array returns empty result", async (t) => {
 	const result = await createResourceIndex([]);
 	t.deepEqual(result, []);
 });
-
-// === firstTruthy ===
-
-test("firstTruthy: returns null for empty array", async (t) => {
-	const result = await firstTruthy([]);
-	t.is(result, null);
-});
-
-test("firstTruthy: returns first truthy value", async (t) => {
-	const result = await firstTruthy([
-		Promise.resolve(null),
-		Promise.resolve("found"),
-		Promise.resolve("also found"),
-	]);
-	t.is(result, "found");
-});
-
-test("firstTruthy: returns null when all resolve to falsy", async (t) => {
-	const result = await firstTruthy([
-		Promise.resolve(null),
-		Promise.resolve(false),
-		Promise.resolve(0),
-	]);
-	t.is(result, null);
-});
-
-test("firstTruthy: rejects when a promise rejects", async (t) => {
-	const error = new Error("test error");
-	await t.throwsAsync(firstTruthy([
-		Promise.resolve(null),
-		Promise.reject(error),
-	]), {message: "test error"});
-});
-
-test("firstTruthy: resolves with first truthy regardless of order", async (t) => {
-	const result = await firstTruthy([
-		new Promise((resolve) => setTimeout(() => resolve(null), 50)),
-		Promise.resolve("immediate"),
-	]);
-	t.is(result, "immediate");
-});