refactor(project): Do not create a CacheManager if cache mode is Off

Author: RandomByte

packages/project/lib/build/cache/ProjectBuildCache.js

@@ -113,7 +113,7 @@ export default class ProjectBuildCache {
 	 * @public
 	 * @param {@ui5/project/specifications/Project} project Project instance
 	 * @param {string} buildSignature Build signature for the current build
-	 * @param {object} cacheManager Cache manager instance
+	 * @param {object|null} cacheManager Cache manager instance
 	 * @param {string} cacheMode Cache mode to use for building UI5 projects
 	 * @returns {Promise<@ui5/project/build/cache/ProjectBuildCache>} Initialized cache instance
 	 */

packages/project/lib/build/helpers/BuildContext.js

@@ -164,6 +164,9 @@ class BuildContext {
 	}
 
 	async getCacheManager() {
+		if (this._buildConfig.cache === Cache.Off) {
+			return null;
+		}
 		if (this.#cacheManager) {
 			return this.#cacheManager;
 		}

packages/project/test/lib/build/helpers/BuildContext.js

@@ -324,6 +324,62 @@ test("getProjectContext", async (t) => {
 	t.is(projectBuildContext, projectBuildContext2);
 });
 
+test("getCacheManager: Returns null when cache mode is 'Off'", async (t) => {
+	const {BuildContext} = t.context;
+
+	const graph = {
+		getRoot: () => ({getType: () => "library", getRootPath: () => ""}),
+	};
+	const buildContext = new BuildContext(graph, "taskRepository", {
+		cache: "Off"
+	});
+
+	const cacheManager = await buildContext.getCacheManager();
+	t.is(cacheManager, null, "Returned null");
+	t.is(t.context.CacheManagerCreate.callCount, 0,
+		"CacheManager.create was not called");
+});
+
+test("getCacheManager: Creates and caches CacheManager for default cache mode", async (t) => {
+	const {BuildContext} = t.context;
+
+	const cacheManagerInstance = {};
+	t.context.CacheManagerCreate.resetBehavior();
+	t.context.CacheManagerCreate.resolves(cacheManagerInstance);
+
+	const graph = {
+		getRoot: () => ({getType: () => "library", getRootPath: () => "/some/path"}),
+	};
+	const buildContext = new BuildContext(graph, "taskRepository");
+
+	const cacheManager1 = await buildContext.getCacheManager();
+	t.is(cacheManager1, cacheManagerInstance, "Returned CacheManager instance");
+	t.is(t.context.CacheManagerCreate.callCount, 1,
+		"CacheManager.create was called once");
+
+	const cacheManager2 = await buildContext.getCacheManager();
+	t.is(cacheManager2, cacheManagerInstance, "Returned same CacheManager instance");
+	t.is(t.context.CacheManagerCreate.callCount, 1,
+		"CacheManager.create was not called again on subsequent invocations");
+});
+
+test("closeCacheManager: No-op when cache mode is 'Off'", async (t) => {
+	const {BuildContext} = t.context;
+
+	const graph = {
+		getRoot: () => ({getType: () => "library", getRootPath: () => ""}),
+	};
+	const buildContext = new BuildContext(graph, "taskRepository", {
+		cache: "Off"
+	});
+
+	await buildContext.getCacheManager();
+
+	t.notThrows(() => {
+		buildContext.closeCacheManager();
+	}, "closeCacheManager does not throw when no CacheManager was created");
+});
+
 test("executeCleanupTasks", async (t) => {
 	const {BuildContext} = t.context;