refactor(builder): Fix Windows test timeouts caused by leaked handles and missing error handler

Close CacheManager in a finally block within buildToTarget() so the
SQLite database is released even when the build throws. Previously,
builds that threw (e.g. SourceChangedDuringBuildError) leaked a refcount,
keeping the DB memory-mapped on Windows and preventing cleanup by
subsequent tests.

Add an error event handler to the JSDoc child process spawn. Without it,
a failed spawn on Windows would never emit close, hanging the promise
indefinitely.

Author: RandomByte

packages/builder/lib/processors/jsdoc/jsdocGenerator.js

@@ -163,10 +163,11 @@ async function buildJsdoc({sourcePath, configPath}) {
 		"--verbose",
 		sourcePath
 	];
-	const exitCode = await new Promise((resolve /* , reject */) => {
+	const exitCode = await new Promise((resolve, reject) => {
 		const child = spawn("node", args, {
 			stdio: ["ignore", "ignore", "inherit"]
 		});
+		child.on("error", reject);
 		child.on("close", resolve);
 	});
 

packages/builder/test/lib/processors/jsdoc/jsdocGenerator.js

@@ -80,7 +80,9 @@ test.serial("buildJsdoc", async (t) => {
 	let exitCode = 0;
 	const cpStub = sinon.stub().returns({
 		on: (event, callback) => {
-			callback(exitCode);
+			if (event === "close") {
+				callback(exitCode);
+			}
 		}
 	});
 

packages/project/lib/build/ProjectBuilder.js

@@ -217,18 +217,21 @@ class ProjectBuilder {
 			});
 		}
 		const pWrites = [];
-		await this.#build(requestedProjects, async (projectName, project, projectBuildContext) => {
-			if (!fsTarget) {
-				// Nothing to write to
-				return;
-			}
-			// Only write requested projects to target
-			// (excluding dependencies that were required to be built, but not requested)
-			this.#log.verbose(`Writing out files for project ${projectName}...`);
-			await this._writeResults(projectBuildContext, fsTarget, pWrites);
-		});
-		await Promise.all(pWrites);
-		this._buildContext.closeCacheManager();
+		try {
+			await this.#build(requestedProjects, async (projectName, project, projectBuildContext) => {
+				if (!fsTarget) {
+					// Nothing to write to
+					return;
+				}
+				// Only write requested projects to target
+				// (excluding dependencies that were required to be built, but not requested)
+				this.#log.verbose(`Writing out files for project ${projectName}...`);
+				await this._writeResults(projectBuildContext, fsTarget, pWrites);
+			});
+			await Promise.all(pWrites);
+		} finally {
+			this._buildContext.closeCacheManager();
+		}
 	}
 
 	/**