refactor: Simplify cache clean

Author: d3xter666

packages/project/lib/cache/CacheCleanup.js

@@ -32,32 +32,6 @@ async function getDirectorySize(dirPath) {
 	return total;
 }
 
-/**
- * Clean a single directory by removing it entirely.
- *
- * @param {string} dirPath Absolute path to directory
- * @param {string} displayPath Path to display in results
- * @param {string} type Type of cache entry
- * @returns {Promise<Array<{path: string, type: string, size: number}>>} Removed entries
- */
-async function cleanDirectory(dirPath, displayPath, type) {
-	const removed = [];
-	try {
-		await fs.access(dirPath);
-	} catch {
-		return removed;
-	}
-
-	const size = await getDirectorySize(dirPath);
-	try {
-		await fs.rm(dirPath, {recursive: true, force: true});
-		removed.push({path: displayPath, type, size});
-	} catch {
-		// Skip on failure
-	}
-	return removed;
-}
-
 /**
  * Clean build cache directory by clearing all records from the SQLite database.
  *
@@ -102,7 +76,11 @@ async function cleanBuildCache(buildCacheDir) {
 }
 
 /**
- * Scans the UI5 data directory and removes all cache entries.
+ * Cleans cache directories for framework libraries and incremental build cache.
+ *
+ * Removes:
+ * - framework/ directory: All UI5 framework libraries, download cache, staging files, and locks
+ * - buildCache/ entries: Clears database records (preserves database files)
  *
  * @param {object} options
  * @param {string} options.ui5DataDir Resolved absolute path to UI5 data directory
@@ -112,33 +90,24 @@ async function cleanBuildCache(buildCacheDir) {
 export async function cleanCache({ui5DataDir}) {
 	const allRemoved = [];
 
-	// Clean framework packages
-	allRemoved.push(...await cleanDirectory(
-		path.join(ui5DataDir, "framework", "packages"),
-		"framework/packages",
-		"framework"
-	));
-
-	// Clean cacache
-	allRemoved.push(...await cleanDirectory(
-		path.join(ui5DataDir, "framework", "cacache"),
-		"framework/cacache",
-		"cacache"
-	));
+	// Clean entire framework directory (packages, cacache, staging, locks, etc.)
+	const frameworkDir = path.join(ui5DataDir, "framework");
+	try {
+		await fs.access(frameworkDir);
+		const size = await getDirectorySize(frameworkDir);
+		await fs.rm(frameworkDir, {recursive: true, force: true});
+		allRemoved.push({
+			path: "framework",
+			type: "framework",
+			size
+		});
+	} catch {
+		// Framework directory doesn't exist or couldn't be removed
+	}
 
-	// Clean build cache (special: clears DB records, not files)
+	// Clean build cache (clears DB records, preserves files)
 	allRemoved.push(...await cleanBuildCache(path.join(ui5DataDir, "buildCache")));
 
-	// Clean misc dirs
-	const miscDirs = [
-		["framework/staging", "staging"],
-		["framework/locks", "locks"],
-		["server", "server"],
-	];
-	for (const [rel, type] of miscDirs) {
-		allRemoved.push(...await cleanDirectory(path.join(ui5DataDir, rel), rel, type));
-	}
-
 	const totalSize = allRemoved.reduce((sum, entry) => sum + entry.size, 0);
 	return {
 		entries: allRemoved,

packages/project/test/lib/cache/CacheCleanup.js

@@ -64,7 +64,7 @@ test("cleanCache: clean all removes framework packages", async (t) => {
 	t.true(result.totalCount >= 1);
 	const frameworkEntries = result.entries.filter((e) => e.type === "framework");
 	t.is(frameworkEntries.length, 1);
-	t.is(frameworkEntries[0].path, "framework/packages");
+	t.is(frameworkEntries[0].path, "framework");
 });
 
 // ===== cleanCache: build cache (full clean) =====