test(project): Adjust test cases for .library changes

Author: matz3

packages/project/test/fixtures/library.d/main/src/library/d/.library

@@ -3,7 +3,7 @@
 
 	<name>library.d</name>
 	<vendor>SAP SE</vendor>
-	<copyright>Some fancy copyright</copyright>
+	<copyright>${copyright}</copyright>
 	<version>${version}</version>
 
 	<documentation>Library D</documentation>

packages/project/test/fixtures/library.d/ui5.yaml

@@ -3,6 +3,7 @@ specVersion: "2.3"
 type: library
 metadata:
   name: library.d
+  copyright: Some fancy copyright
 resources:
   configuration:
     paths:

packages/project/test/lib/build/BuildServer.integration.js

@@ -99,30 +99,47 @@ test.serial("Serve application.a, request library resource", async (t) => {
 
 	// Change a source file in library.a
 	const changedFilePath = `${fixtureTester.fixturePath}/node_modules/collection/library.a/src/library/a/.library`;
-	await fs.appendFile(changedFilePath, `\n<!-- Test -->\n`);
+	await fs.writeFile(
+		changedFilePath,
+		(await fs.readFile(changedFilePath, {encoding: "utf8"})).replace(
+			`<documentation>Library A</documentation>`,
+			`<documentation>Library A (updated #1)</documentation>`
+		)
+	);
 
 	await setTimeout(500); // Wait for the file watcher to detect and propagate the change
 
 	// #3 request with cache and changes
-	const res = await fixtureTester.requestResource("/resources/library/a/.library", {
+	const dotLibraryResource = await fixtureTester.requestResource("/resources/library/a/.library", {
 		projects: {
 			"library.a": {
 				skippedTasks: [
-					"enhanceManifest",
 					"escapeNonAsciiCharacters",
 					"minify",
-					// Note: replaceCopyright is skipped because no copyright is configured in the project
 					"replaceBuildtime",
-					"replaceCopyright",
-					"replaceVersion",
 				]
 			}
 		}
 	});
 
-	// Check whether the changed file is in the destPath
-	const servedFileContent = await res.getString();
-	t.true(servedFileContent.includes(`<!-- Test -->`), "Resource contains changed file content");
+	// Check whether the changed file is served
+	const servedFileContent = await dotLibraryResource.getString();
+	t.true(
+		servedFileContent.includes(`<documentation>Library A (updated #1)</documentation>`),
+		"Resource contains changed file content"
+	);
+
+	// #4 request with cache (no changes)
+	const manifestResource = await fixtureTester.requestResource("/resources/library/a/manifest.json", {
+		projects: {}
+	});
+
+	// Check whether the manifest is served correctly with changed .library content reflected
+	const manifestContent = JSON.parse(await manifestResource.getString());
+	t.is(
+		manifestContent["sap.app"]["description"], "Library A (updated #1)",
+		"Manifest reflects changed .library content"
+	);
 });
 
 function getFixturePath(fixtureName) {

packages/project/test/lib/build/ProjectBuilder.integration.js

@@ -204,30 +204,38 @@ test.serial("Build library.d project multiple times", async (t) => {
 	await fs.writeFile(
 		changedFilePath,
 		(await fs.readFile(changedFilePath, {encoding: "utf8"})).replace(
-			`<copyright>Some fancy copyright</copyright>`,
-			`<copyright>Some new fancy copyright</copyright>`
+			`<documentation>Library D</documentation>`,
+			`<documentation>Library D (updated #1)</documentation>`
 		)
 	);
 
 	// #3 build (with cache, with changes)
 	await fixtureTester.buildProject({
 		config: {destPath, cleanDest: true},
 		assertions: {
-			projects: {"library.d": {}}
+			projects: {"library.d": {
+				skippedTasks: [
+					"buildThemes",
+					"escapeNonAsciiCharacters",
+					"minify",
+					"replaceBuildtime",
+				]
+			}}
 		}
 	});
 
-	// Check whether the changed file is in the destPath
+	// Check whether the changes are in the destPath
 	const builtFileContent = await fs.readFile(`${destPath}/resources/library/d/.library`, {encoding: "utf8"});
 	t.true(
-		builtFileContent.includes(`<copyright>Some new fancy copyright</copyright>`),
+		builtFileContent.includes(`<documentation>Library D (updated #1)</documentation>`),
 		"Build dest contains changed file content"
 	);
-	// Check whether the updated copyright replacement took place
-	const builtSomeJsContent = await fs.readFile(`${destPath}/resources/library/d/some.js`, {encoding: "utf8"});
+
+	// Check whether the manifest.json was updated with the new documentation
+	const manifestContent = await fs.readFile(`${destPath}/resources/library/d/manifest.json`, {encoding: "utf8"});
 	t.true(
-		builtSomeJsContent.includes(`Some new fancy copyright`),
-		"Build dest contains updated copyright in some.js"
+		manifestContent.includes(`"Library D (updated #1)"`),
+		"Build dest contains updated description in manifest.json"
 	);
 
 	// #4 build (with cache, no changes)
@@ -237,6 +245,8 @@ test.serial("Build library.d project multiple times", async (t) => {
 			projects: {}
 		}
 	});
+
+	// TODO: Change copyright in ui5.yaml and expect that a full rebuild is triggered
 });
 
 test.serial("Build theme.library.e project multiple times", async (t) => {