Skip to content

Commit 8464931

Browse files
committed
docs: Fix typo
1 parent 480d3e0 commit 8464931

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

rfcs/0020-npm-package-integration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ The solution consists of four phases working together:
7171

7272
- **Phase 2: Rollup Bundler** — Each detected NPM package is fed to the Rollup build pipeline as an entry point. Rollup resolves entry points and discovers transitive dependencies automatically via `@rollup/plugin-node-resolve`. The externals configuration prevents shared dependencies from being duplicated (e.g., `react` is external to `react-dom`'s bundle). The plugin transformation chain converts code through CJS -> ESM -> tree-shaken ESM -> AMD (`sap.ui.define`). External references are remapped via `paths` so that the UI5 module loader can resolve them at runtime (e.g., `'react'` -> `'thirdparty/react'`). Packages are bundled in topological order so that dependencies are available before dependents. Output: optimized AMD modules (e.g., `react.js` 19KB, `react-dom.js` 577KB with AMD dependency on `thirdparty/react`).
7373

74-
- **Phase 3: Output Writer** — Bundled AMD modules are written to `resources/thirdparty/*.js` in the workspace. When `addToNamespace: true` (the default for Fiori Launchpad compatibility), source file paths are rewritten to include the component namespace prefix. Output: final files ready for deployment (e.g., `chart.js.js` as a standalone module, `react.js` and `react-dom.js` with AMD inter-dependencies, `@ui5/webcomponents/` with generated UI5 control wrappers).
74+
- **Phase 3: Output Writer** — Bundled AMD modules are written to `resources/thirdparty/*.js` in the workspace. When `addToNamespace: true` (the default for Fiori Launchpad compatibility), source file paths are rewritten to include the component namespace prefix. Output: final files ready for deployment (e.g., `chart.js` as a standalone module, `react.js` and `react-dom.js` with AMD inter-dependencies, `@ui5/webcomponents/` with generated UI5 control wrappers).
7575

7676
**Key Principles:**
7777

0 commit comments

Comments
 (0)