test(project): Address review of @RandomByte

Author: maxreichmann

packages/project/test/fixtures/application.a/custom-tasks-2/custom-task-0.js

@@ -1,19 +1,22 @@
+const Logger = require("@ui5/logger");
+const log = Logger.getLogger("builder:tasks:customTask0");
+
 let buildRanOnce;
 module.exports = async function ({
 	workspace, taskUtil,
 	options: {projectNamespace}
 }) {
-	console.log("Custom task 0 executed");
+	log.verbose("Custom task 0 executed");
 
 	// Read a file to trigger execution of this task:
 	const testJS = await workspace.byPath(`/resources/${projectNamespace}/test.js`);
 
 	if (buildRanOnce != true) {
-		console.log("Flag NOT set -> We are in #1 Build still");
+		log.verbose("Flag NOT set -> We are in #1 Build still");
 		buildRanOnce = true;
 		taskUtil.setTag(testJS, taskUtil.STANDARD_TAGS.IsDebugVariant);
 	} else {
-		console.log("Flag set -> We are in #2 Build");
+		log.verbose("Flag set -> We are in #2 Build");
 		taskUtil.setTag(testJS, taskUtil.STANDARD_TAGS.OmitFromBuildResult);
 	}
 };

packages/project/test/fixtures/application.a/custom-tasks-2/custom-task-1.js

@@ -1,22 +1,29 @@
+const Logger = require("@ui5/logger");
+const log = Logger.getLogger("builder:tasks:customTask1");
+
 let buildRanOnce;
 module.exports = async function ({
 	workspace, taskUtil,
 	options: {projectNamespace}
 }) {
-	console.log("Custom task 1 executed");
+	log.verbose("Custom task 1 executed");
 
 	// Read a file to trigger execution of this task:
 	const testJS = await workspace.byPath(`/resources/${projectNamespace}/test.js`);
 
 	if (buildRanOnce != true) {
-		console.log("Flag NOT set -> We are in #1 Build still");
+		log.verbose("Flag NOT set -> We are in #1 Build still");
 		buildRanOnce = true;
 		const tag = taskUtil.getTag(testJS, taskUtil.STANDARD_TAGS.IsDebugVariant);
 		if (!tag) {
 			throw new Error("Tag set during #1 Build is not readable, which is UNEXPECTED.");
 		}
 	} else {
-		console.log("Flag set -> We are in #2 Build");
+		const previousTag = taskUtil.getTag(testJS, taskUtil.STANDARD_TAGS.IsDebugVariant);
+		if (previousTag) {
+			throw new Error("Tag set during #1 Build is still readable, which is UNEXPECTED.");
+		}
+		log.verbose("Flag set -> We are in #2 Build");
 		const tag = taskUtil.getTag(testJS, taskUtil.STANDARD_TAGS.OmitFromBuildResult);
 		if (!tag) {
 			throw new Error("Tag set during #2 Build is not readable, which is UNEXPECTED.");

packages/project/test/fixtures/application.a/task.dependency-change.js

@@ -1,11 +1,11 @@
-// This is a modified version of the compileLicenseSummary example of the UI5 CLI.
+// This is a modified version of the compileLicenseSummary example of the UI5 CLI documentation.
 // (https://github.com/UI5/cli/blob/b72919469d856508dd757ecf325a5fb45f15e56d/internal/documentation/docs/pages/extensibility/CustomTasks.md#example-libtaskscompilelicensesummaryjs)
 
-module.exports = async function ({dependencies, log, taskUtil, workspace, options: {projectNamespace}}) {
+module.exports = async function ({log, taskUtil, workspace}) {
 	const {createResource} = taskUtil.resourceFactory;
     const projectsVisited = new Set();
 
-    async function processProject(project) {
+    async function processProject() {
 		return Promise.all(taskUtil.getDependencies().map(async (projectName) => {
             if (projectName !== "library.d") {
 				return;
@@ -17,7 +17,7 @@ module.exports = async function ({dependencies, log, taskUtil, workspace, option
             const project = taskUtil.getProject(projectName);
 			const newLibraryFile = await project.getReader().byGlob("**/newLibraryFile.js");
 			if (newLibraryFile.length > 0) {
-				console.log('New Library file found. We are in #4 build.');
+				log.verbose('New Library file found. We are in #4 build.');
 				// Change content of application.a:
 				const applicationResource = await workspace.byPath("/resources/id1/test.js");
 				const content = (await applicationResource.getString()) + "\n console.log('something new');";
@@ -26,7 +26,7 @@ module.exports = async function ({dependencies, log, taskUtil, workspace, option
         			string: content
     			}));
             } else {
-				console.log(`New Library file not found. We are still in an earlier build.`);
+				log.verbose(`New Library file not found. We are still in an earlier build.`);
             }
             return processProject(project);
         }));