Skip to content

Commit c61fc13

Browse files
ci: Add engine compatibility check for PRs (external package) (#1360)
Initial idea: #1356 JIRA: CPOUI5FOUNDATION-1225 `check-engine-light` is run as a regular CI step — if all dependencies are compatible it exits silently, and if any are incompatible it exits with code 1, failing the build. --------- Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
1 parent d913c56 commit c61fc13

3 files changed

Lines changed: 29 additions & 2 deletions

File tree

.github/workflows/github-ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ permissions:
1212
contents: read
1313

1414
jobs:
15+
1516
test:
1617
name: General checks and tests
1718
runs-on: ubuntu-24.04
@@ -25,7 +26,10 @@ jobs:
2526
node-version: 22.20.0
2627

2728
- name: Install dependencies
28-
run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo
29+
run: npm ci
30+
31+
- name: Check Node.js engine compatibility
32+
run: npm run check-engine
2933

3034
- name: Check package.json "engines" consistency
3135
run: |

package-lock.json

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"unit": "npm run unit --workspaces --if-present",
3030
"coverage": "npm run coverage --workspaces --if-present",
3131
"knip": "knip --config knip.config.js",
32+
"check-engine": "check-engine-light .",
3233
"check-licenses": "licensee --errors-only",
3334
"schema-generate": "npm run schema-generate --workspace=@ui5/documentation",
3435
"generate-cli-doc": "npm run generate-cli-doc --workspace=@ui5/documentation"
@@ -48,7 +49,8 @@
4849
"globals": "^17.3.0",
4950
"husky": "^9.1.7",
5051
"knip": "^5.83.0",
51-
"licensee": "^11.1.1"
52+
"licensee": "^11.1.1",
53+
"check-engine-light": "0.4.0"
5254
},
5355
"overrides": {
5456
"pacote@<=20": {

0 commit comments

Comments
 (0)