fix: Improve handling of css classes in docdash publish.js

Author: matz3

internal/documentation/jsdoc/docdash/publish.js

@@ -512,7 +512,7 @@ exports.publish = function(taffyData, opts, tutorials) {
 // Taken from templateHelper.js in jsdoc/util
 
 function linkTo(longname, linkText, cssClass, fragmentId) {
-	const classString = cssClass ? util.format(' class="%s"', cssClass) : '';
+	const classString = getCssClassString(cssClass);
 	let fileUrl;
 	let fragmentString = fragmentId ? `#${fragmentId}` : '';
 	let stripped;
@@ -612,7 +612,7 @@ function isComplexTypeExpression(expr) {
 }
 
 function linkComplexType(longname, linkText, cssClass) {
-	const classString = cssClass ? util.format(' class="%s"', cssClass) : '';
+	const classString = getCssClassString(cssClass);
 
 	// Handle type unions (e.g., "string | number")
 	if (/^.+\|.+$/.test(longname) && !/<.+>/.test(longname)) {
@@ -630,7 +630,7 @@ function linkComplexType(longname, linkText, cssClass) {
 
 	// Handle generic types (e.g., "Array.<string>", "Promise.<@ui5/fs/Resource>")
 	if (/<.+>/.test(longname)) {
-		return linkGenericType(longname, classString);
+		return linkGenericType(longname, cssClass);
 	}
 
 	// Handle record types (e.g., "{a: string, b: number}")
@@ -642,7 +642,8 @@ function linkComplexType(longname, linkText, cssClass) {
 	return linkText || htmlsafe(longname);
 }
 
-function linkGenericType(type, classString) {
+function linkGenericType(type, cssClass) {
+	const classString = getCssClassString(cssClass);
 	// Match patterns like "Promise.<Type>" or "Array.<Type>" or "Promise.<Array.<Type>>"
 	const match = type.match(/^([^<]+)<(.+)>$/);
 
@@ -672,7 +673,7 @@ function linkGenericType(type, classString) {
 
 	// Recursively handle the inner type
 	if (isComplexTypeExpression(innerType)) {
-		result += linkComplexType(innerType, null, classString.replace(' class="', '').replace('"', ''));
+		result += linkComplexType(innerType, null, cssClass);
 	} else {
 		let innerUrl = helper.longnameToUrl[innerType];
 		if (innerUrl) {
@@ -688,3 +689,7 @@ function linkGenericType(type, classString) {
 
 	return result;
 }
+
+function getCssClassString(cssClass) {
+	return cssClass ? util.format(' class="%s"', cssClass) : '';
+}