refactor: Throw if both Component.js & Component.js exist at the same time

Author: maxreichmann

packages/project/lib/specifications/types/Component.js

@@ -291,10 +291,17 @@ class Component extends ComponentProject {
 	}
 
 	async _ensureComponent() {
-		// Ensure that a Component.js/ts exists
-		const componentResource = await this._getRawSourceReader().byPath("/Component.js") ||
-			await this._getRawSourceReader().byPath("/Component.ts");
-		if (!componentResource) {
+		// Throw if neither Component.js nor Component.ts is present
+		// or if both are present
+		const componentJSResource = await this._getRawSourceReader().byPath("/Component.js");
+		const componentTSResource = await this._getRawSourceReader().byPath("/Component.ts");
+		if (componentJSResource && componentTSResource) {
+			throw new Error(
+				`Both "Component.js" and "Component.ts" found` +
+				` in component project ${this.getName()}`
+			);
+		}
+		if (!componentJSResource && !componentTSResource) {
 			throw new Error(
 				`Unable to find either required "Component.js" or "Component.ts"` +
 				` in component project ${this.getName()}`

packages/project/test/fixtures/component.h/src-with-component-js-and-component-ts/Component.js

@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/UIComponent"], function(UIComponent){
+	"use strict";
+	return UIComponent.extend('application.h.Component', {
+		metadata: {
+			manifest: "json"
+		}
+	});
+});

packages/project/test/fixtures/component.h/src-with-component-js-and-component-ts/Component.ts

@@ -0,0 +1,7 @@
+import UIComponent from "sap/ui/core/UIComponent";
+
+export default class Component extends UIComponent {
+    public static metadata = {
+        "manifest": "json"
+    };
+};

packages/project/test/fixtures/component.h/src-with-component-js-and-component-ts/manifest.json

@@ -0,0 +1,13 @@
+{
+    "_version": "1.1.0",
+    "sap.app": {
+        "_version": "1.1.0",
+        "id": "${componentName}",
+        "type": "application",
+        "applicationVersion": {
+            "version": "1.2.2"
+        },
+        "embeds": ["embedded"],
+        "title": "{{title}}"
+    }
+}

packages/project/test/lib/specifications/types/Component.js

@@ -697,3 +697,11 @@ test("Do not throw when Component.ts exists", async (t) => {
 	componentHInput.configuration.resources.configuration.paths.src = "src-with-component-ts";
 	await t.notThrowsAsync(Specification.create(componentHInput), "Should not throw an error");
 });
+
+test("Throw when both Component.js and Component.ts exist", async (t) => {
+	const {componentHInput} = t.context;
+	componentHInput.configuration.resources.configuration.paths.src = "src-with-component-js-and-component-ts";
+	const error = await t.throwsAsync(Specification.create(componentHInput));
+	t.is(error.message,
+		"Both \"Component.js\" and \"Component.ts\" found in component project component.h");
+});