Skip to content

Commit ef91a28

Browse files
committed
test(logger): Cover case for message with level 'silent'
1 parent 051a412 commit ef91a28

2 files changed

Lines changed: 18 additions & 2 deletions

File tree

packages/logger/lib/writers/Console.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,9 +440,9 @@ class Console {
440440
return chalk.yellow(level);
441441
case "error":
442442
return chalk.bgRed.white(level);
443-
// Log level silent does not produce messages
444443
default:
445-
return level;
444+
// Log level silent does not produce messages
445+
throw new Error(`writers/Console: Invalid message log level "${level}"`);
446446
}
447447
}
448448

packages/logger/test/lib/writers/Console.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,22 @@ test.serial("Log event", (t) => {
3232
"Logged expected message");
3333
});
3434

35+
test.serial("Log event with invalid log level 'silent'", (t) => {
36+
const {stderrWriteStub} = t.context;
37+
38+
t.throws(() => {
39+
process.emit("ui5.log", {
40+
level: "silent",
41+
message: "Message 1",
42+
moduleName: "my:module"
43+
});
44+
}, {
45+
message: `writers/Console: Invalid message log level "silent"`
46+
});
47+
48+
t.is(stderrWriteStub.callCount, 0, "Logged no message");
49+
});
50+
3551
test.serial("Enable", (t) => {
3652
const {stderrWriteStub} = t.context;
3753

0 commit comments

Comments
 (0)