Conversation
flovogt
force-pushed
the
rename-to-ui5-cli
branch
from
ae32e9e to
bf47265
Compare
d3xter666
reviewed
Sep 9, 2025
Member
d3xter666
left a comment
d3xter666
left a comment
There was a problem hiding this comment.
I cannot comment on non modified code, so I'll write it here.
Search for "To separate "UI5 Projects" (i.e. things that represent UI5-artifacts for the browser) from tooling specific things"
IMO, it should be:
"To separate "UI5 Projects" (i.e. things that represent UI5-artifacts for the browser) from UI5 CLI specific things"
Maniy static assets and folders have the UI5 Tooling name, for example: ./resources/UI5_Tooling_Resource_Tagging_Classes.png.
IMO, we need to rename those, too
Please, take a look at ui5-tooling/site/schema/ui5.yaml.json. There's relevant info that needs to be updated there, too. (npm run schema-generate)
flovogt
force-pushed
the
rename-to-ui5-cli
branch
from
bf47265 to
6be3554
Compare
For further insights, see https://community.sap.com/t5/technology-blog-posts-by-sap/goodbye-ui5-tooling-hello-ui5-cli/ba-p/14211769. JIRA: CPOUI5FOUNDATION-1098
flovogt
force-pushed
the
rename-to-ui5-cli
branch
from
6be3554 to
a6302bd
Compare
d3xter666
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For further insights, see https://community.sap.com/t5/technology-blog-posts-by-sap/goodbye-ui5-tooling-hello-ui5-cli/ba-p/14211769.
JIRA: CPOUI5FOUNDATION-1098