refactor: Integrate @ui5/project into the monorepo#1121
Merged
Conversation
…5-project#669) Fixes: #887 ProjectBuilder was using a singleton of the logger module. Basically, the logger was constructed only once, during module evaluation, but used throughout the whole module. The tricky part is that the `ProjectBuilder`'s logger has this `setProjects()` method that acts as an allow list of the projects being built. As the logger used to be a singleton within this module/class and the async behaviour of the whole module, calling `setProject()` was polluting the internal `projects` property. With this fix, every `ProjectBuilder` instance has its own`BuildLogger` instance that solves the issue.
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.1 to 4.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.8.1...v4.0.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The GitHub file finder feature assumes "build/" directories contain generated code and therefore ignores them. This change configures lib/build/* to not be treated as generated code. Resources: * https://github.blog/changelog/2022-07-28-file-finder-customize-default-exclusions/ * https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github GitHub Support Ticket: https://github.com/SAP/ui5-project/issues/2427846
SAP/ui5-project#677) JIRA: CPOUI5FOUNDATION-751 \@ui5/builder PR that depends on this change: SAP/ui5-builder#953 When cleaning up after tasks run, it can happen in couple cases: - When the project is build - When there's a SIGTERM signal - (Maybe) on some error We need to be able to distinguish between those cases as in some places we rely on graceful termination and cleanup. Especially, after the project has been build successfully. On the other hand when the user presses `Ctrl + C`, for example, we need to enforce the termination. This cahnge provides this context. --------- Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com> Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
File finder still won't find files in lib/build/ dir, so GitHub support suggested adding these lines for further investigation. Follow up to SAP/ui5-project#679 GitHub Support Ticket: https://github.com/SAP/ui5-project/issues/2427846
GitHub Support suggests to add this line since thir default configuration uses the pattern "build/**" too. Follow up to SAP/ui5-project#680 GitHub Support Ticket: https://github.com/SAP/ui5-project/issues/2427846
…roject#673) This change provide a `ui5.yaml` schema definition for the following feature: SAP/ui5-builder#951 JIRA: CPOUI5FOUNDATION-744
…t flat build output (SAP/ui5-project#624) New option `outputStyle`. Whether to omit the `/resources/<namespace>` directory structure in the build output. Resolves #507 --------- Co-authored-by: Yavor Ivanov <yavor.ivanov@sap.com> Co-authored-by: Yavor Ivanov <d3xter666@users.noreply.github.com> Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
JIRA: CPOUI5FOUNDATION-617
JIRA: CPOUI5FOUNDATION-1098
…5-project#822) - Do not request packages that are part of the test fixtures from npm, but redirect them to void endpoint. - Add scoping to the projects, so that they are requested only from `@ui5` npm org that we can control.
Changelog of this version: https://github.com/SAP/ui5-fs/blob/v4.0.2/CHANGELOG.md
JIRA: CPOUI5FOUNDATION-975
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
matz3
approved these changes
Sep 25, 2025
Member
Author
|
This branch has been merged incorectly with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-975