ci: Integrate "project" into monorepo setup#1148
Merged
maxreichmann merged 3 commits intomainfrom Oct 13, 2025
Merged
Conversation
maxreichmann
commented
Oct 10, 2025
Comment on lines
140
to
147
| "peerDependencies": { | ||
| "@ui5/builder": "^4.0.11" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "@ui5/builder": { | ||
| "optional": true | ||
| } | ||
| }, |
Member
Author
There was a problem hiding this comment.
@UI5/ui5-team-cor-fnd These settings stay untouched?
Member
There was a problem hiding this comment.
IMO, yes! These are on package level i.e. when installing the @ui5/project and checking its dependencies.
Member
There was a problem hiding this comment.
Yes, they should remain as-is 👍
RandomByte
requested changes
Oct 13, 2025
maxreichmann
force-pushed
the
enable-github-actions-project
branch
from
4a63948 to
74fb4c6
Compare
Member
Author
|
Rebased |
RandomByte
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-1139