Conversation
…flexBundle' property to the manifest.json (#1164) JIRA: CPOUI5FOUNDATION-1125 --------- Co-authored-by: Christian Voshage <christian.voshage@sap.com>
|
should we use "feat(packages/builder):" as commit message header? |
|
We should update https://github.com/UI5/cli/blob/main/docs/Guidelines.md, as it still mentions the OpenUI5-style commit message guidelines. There, we should document how we want to use the |
|
Also, we still don't have any conventional commit lint checks. |
Shall we address all those here? Or maybe this change can wait until we have decided on those? |
|
It should be tackled as part of CPOUI5FOUNDATION-1152. I would prefer to wait on that before merging this change. It doesn't block a release of the feature in v4. We just need to ensure that this PR is merged before we produce the first v5 release. |
|
The commit message references the original PR from ui5-builder "1164", which is now here linked to a different PR with the same number. The number should be removed from the title and a full link should be added to the commit message body. |
|
@d3xter666 please use squash and merge to apply the changed commit message ( |
…anifest.json When running the `generateFlexChangesBundle` task, `manifest.json` might not be present. Follow-up of #1165
…ing manifest.json When running the `generateFlexChangesBundle` task, `manifest.json` might not be present. Follow-up of #1165
JIRA: CPOUI5FOUNDATION-1125