ci: Fail-fast "npm ci" if deps require unsupported node version#1172
Merged
maxreichmann merged 5 commits intomainfrom Oct 28, 2025
Merged
ci: Fail-fast "npm ci" if deps require unsupported node version#1172maxreichmann merged 5 commits intomainfrom
maxreichmann merged 5 commits intomainfrom
Conversation
maxreichmann
force-pushed
the
ci-node-engine-strict
branch
2 times, most recently
from
ba38125 to
142829c
Compare
maxreichmann
force-pushed
the
ci-node-engine-strict
branch
from
142829c to
8bf5b5a
Compare
matz3
reviewed
Oct 28, 2025
Member
matz3
left a comment
matz3
left a comment
There was a problem hiding this comment.
The individual package.json files (within the packages folder) should also be aligned with this change.
Member
Author
|
@UI5/ui5-team-cor-fnd |
RandomByte
previously approved these changes
Oct 28, 2025
RandomByte
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+ci(package.json): Update node version to current LTS (22) + latest (24)+ci(github-ci.yml): Update node version to current LTS (22)+ci(test.yml): Remove node20 for test matrixWhen upgrading a dependency to a newer version, it might require a different node version than before which could be unsupported by the repo. Unfortunately, this could be easily overseen.
This PR adds the flag
--engine-strictto the dependency installation step during the GH Actions job. Incase such a version requirement change, this flag will now fail-fast the job which should attract attention.