Skip to content

ci: Fail-fast "npm ci" if deps require unsupported node version #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxreichmann merged 5 commits into from
Oct 28, 2025
Merged

ci: Fail-fast "npm ci" if deps require unsupported node version #1172

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42225cc
ci: Fail-fast "npm ci" if deps require unsupported node version
maxreichmann Oct 27, 2025
8bf5b5a
ci(package.json): Update node version to current LTS + latest
maxreichmann Oct 27, 2025
9b8a759
ci(all packages): Update node version in package.json
maxreichmann Oct 28, 2025
61375f8
ci(all packages): Use node 22.20.0 instead of 22.21.0
maxreichmann Oct 28, 2025
ee15105
ci: Remove Node20 for test matrix
maxreichmann Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/github-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: 20.11.0
node-version: 22.20.0

- name: Install dependencies
run: npm ci
run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo

- name: Perform ESLint check
run: npm run lint
Expand Down
20 changes: 10 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
],
"type": "module",
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/builder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"./internal/jsdoc/template/publish": "./lib/processors/jsdoc/lib/ui5/template/publish.js"
},
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/documentation/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/documentation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
],
"type": "module",
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
}
}
}
2 changes: 1 addition & 1 deletion packages/fs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"./internal/ResourceTagCollection": "./lib/ResourceTagCollection.js"
},
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"./internal/loggers/*": "./lib/loggers/*.js"
},
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/project/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"./package.json": "./package.json"
},
"engines": {
"node": "^20.11.0 || >=22.0.0",
"node": "^22.20.0 || >=24.0.0",
"npm": ">= 8"
},
"scripts": {
Expand Down
Loading