Conversation
maxreichmann
force-pushed
the
setup-coveralls-monorepo
branch
from
e7fc593 to
d8b0868
Compare
maxreichmann
force-pushed
the
setup-coveralls-monorepo
branch
5 times, most recently
from
11a4c09 to
f44efd7
Compare
|
|
||
| - name: Run unit tests | ||
| run: npm run coverage | ||
| run: npm run unit |
There was a problem hiding this comment.
You can run external gh action and wait to complete.
Check this sample here: https://github.com/UI5/cli/pull/1173/files#diff-40a82b574505e06738cecbb56e70a40cb758eb7340d0531952d5d7e173f07769R38-R43
In this case, the coverage.yml can be triggered from here
There was a problem hiding this comment.
I considered this, but I'm not sure if we want to introduce so many dependencies within workflows. I personally prefer it more encapsulated for this regard (even though it's slower).
There was a problem hiding this comment.
I think the separate workflow is fine, but with that we could question whether we actually need to run the tests in this workflow at all. As long as the coverage workflow also uses the minimum required Node.js version, I don't see a benefit of running the tests again in github-ci.yml.
maxreichmann
force-pushed
the
setup-coveralls-monorepo
branch
10 times, most recently
from
2f31ac1 to
c3b4d8f
Compare
maxreichmann
force-pushed
the
setup-coveralls-monorepo
branch
from
c3b4d8f to
cf8ffa8
Compare
4 participants
JIRA: CPOUI5FOUNDATION-1153