From 44737d5f83ce7cc6156d974406cfd9a662021d7f Mon Sep 17 00:00:00 2001 From: Matthias Osswald Date: Mon, 8 Dec 2025 14:06:20 +0100 Subject: [PATCH 1/2] build: Use 'next' tag for package download --- internal/documentation/scripts/downloadPackages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/documentation/scripts/downloadPackages.sh b/internal/documentation/scripts/downloadPackages.sh index 0f434195186..d216295f8b3 100755 --- a/internal/documentation/scripts/downloadPackages.sh +++ b/internal/documentation/scripts/downloadPackages.sh @@ -2,7 +2,7 @@ set -euo pipefail # Constants -readonly UI5_CLI_PACKAGES_VERSION="latest" +readonly UI5_CLI_PACKAGES_VERSION="next" readonly UI5_CLI_PACKAGES=($(find ../../packages/*/package.json -exec jq -r '.name' {} \;)) # Directories From 492ece4c3f6300e241b49f5e876db26c09e5c12c Mon Sep 17 00:00:00 2001 From: Matthias Osswald Date: Mon, 8 Dec 2025 14:05:47 +0100 Subject: [PATCH 2/2] refactor: Fix shellcheck findings --- internal/documentation/scripts/downloadPackages.sh | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/internal/documentation/scripts/downloadPackages.sh b/internal/documentation/scripts/downloadPackages.sh index d216295f8b3..3e0154e415f 100755 --- a/internal/documentation/scripts/downloadPackages.sh +++ b/internal/documentation/scripts/downloadPackages.sh @@ -3,10 +3,14 @@ set -euo pipefail # Constants readonly UI5_CLI_PACKAGES_VERSION="next" -readonly UI5_CLI_PACKAGES=($(find ../../packages/*/package.json -exec jq -r '.name' {} \;)) +UI5_CLI_PACKAGES=() +while IFS= read -r pkg; do + UI5_CLI_PACKAGES+=("$pkg") +done < <(find ../../packages/*/package.json -exec jq -r '.name' {} \;) # Directories -readonly SCRIPT_DIR="$(dirname -- "$0")" +SCRIPT_DIR="$(dirname -- "$0")" +readonly SCRIPT_DIR readonly DOC_ROOT="${SCRIPT_DIR}/.." readonly TMP_PACKAGES_DIR="./tmp/packages" @@ -31,8 +35,9 @@ download_packages() { for package in "${UI5_CLI_PACKAGES[@]}"; do echo "Downloading and extracting $package..." npm pack "$package@$UI5_CLI_PACKAGES_VERSION" --workspaces false --quiet --pack-destination "$TMP_PACKAGES_DIR" - local package_file_name="$(extract_package_file_name "$package")" - rm -rf "$TMP_PACKAGES_DIR/${package}" + local package_file_name + package_file_name="$(extract_package_file_name "$package")" + rm -rf "$TMP_PACKAGES_DIR/${package:?}" mkdir -p "$TMP_PACKAGES_DIR/${package}" tar -xzf "$TMP_PACKAGES_DIR/${package_file_name}"-*.tgz --strip-components=1 -C "$TMP_PACKAGES_DIR/${package}" rm "$TMP_PACKAGES_DIR/${package_file_name}"-*.tgz