fix(project): Allow Component.ts#1243
Merged
maxreichmann merged 6 commits intomainfrom Dec 15, 2025
Merged
Conversation
…itive due to Component.ts)
maxreichmann
force-pushed
the
fix/allow-component.ts
branch
from
222220f to
85f7366
Compare
d3xter666
reviewed
Dec 12, 2025
| // or if both are present | ||
| const componentJSResource = await this._getRawSourceReader().byPath("/Component.js"); | ||
| const componentTSResource = await this._getRawSourceReader().byPath("/Component.ts"); | ||
| if (componentJSResource && componentTSResource) { |
Member
There was a problem hiding this comment.
I would expect this to be a real use case, where the output dir is the same as source dir.
In such case, IMO we should check only the TS file as it must be the source for the JS.
Let the others say what do they think about it
Member
There was a problem hiding this comment.
I agree, I think it should ne fine if both are present. We only want to ensure that at least one Component file exists
--> only throw when both are missing
d3xter666
reviewed
Dec 12, 2025
Comment on lines
+294
to
+295
| // Throw if neither Component.js nor Component.ts is present | ||
| // or if both are present |
Member
There was a problem hiding this comment.
This comment seems outdated now
d3xter666
approved these changes
Dec 15, 2025
RandomByte
approved these changes
Dec 15, 2025
d3xter666
pushed a commit
that referenced
this pull request
Dec 15, 2025
🚜 New release prepared --- <details><summary>builder: 5.0.0-alpha.2</summary> ## [5.0.0-alpha.2](builder-v5.0.0-alpha.1...builder-v5.0.0-alpha.2) (2025-12-15) ### chore * **builder:** Synchronize ui5-cli-packages versions ### Dependencies * The following workspace dependencies were updated * dependencies * @ui5/fs bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/logger bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * devDependencies * @ui5/project bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 </details> <details><summary>cli: 5.0.0-alpha.2</summary> ## [5.0.0-alpha.2](cli-v5.0.0-alpha.1...cli-v5.0.0-alpha.2) (2025-12-15) ### chore * **cli:** Synchronize ui5-cli-packages versions ### Dependencies * The following workspace dependencies were updated * dependencies * @ui5/builder bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/fs bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/logger bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/project bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/server bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 </details> <details><summary>fs: 5.0.0-alpha.2</summary> ## [5.0.0-alpha.2](fs-v5.0.0-alpha.1...fs-v5.0.0-alpha.2) (2025-12-15) ### chore * **fs:** Synchronize ui5-cli-packages versions ### Dependencies * The following workspace dependencies were updated * dependencies * @ui5/logger bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 </details> <details><summary>logger: 5.0.0-alpha.2</summary> ## [5.0.0-alpha.2](logger-v5.0.0-alpha.1...logger-v5.0.0-alpha.2) (2025-12-15) ### chore * **logger:** Synchronize ui5-cli-packages versions </details> <details><summary>project: 5.0.0-alpha.2</summary> ## [5.0.0-alpha.2](project-v5.0.0-alpha.1...project-v5.0.0-alpha.2) (2025-12-15) ### Bug Fixes * **project:** Allow Component.ts ([#1243](#1243)) ([3b8ce29](3b8ce29)) ### Dependencies * The following workspace dependencies were updated * dependencies * @ui5/fs bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/logger bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * peerDependencies * @ui5/builder bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 </details> <details><summary>server: 5.0.0-alpha.2</summary> ## [5.0.0-alpha.2](server-v5.0.0-alpha.1...server-v5.0.0-alpha.2) (2025-12-15) ### chore * **server:** Synchronize ui5-cli-packages versions ### Dependencies * The following workspace dependencies were updated * dependencies * @ui5/builder bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/fs bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * @ui5/logger bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 * devDependencies * @ui5/project bumped from ^5.0.0-alpha.1 to ^5.0.0-alpha.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1242.
This allows the use of TS for Component files.