Skip to content

ci: Do not fail ci if Coverage reporting fails#1244

Closed
maxreichmann wants to merge 1 commit intomainfrom
ci/do-not-fail-ci-on-coveralls-downtimes
Closed

ci: Do not fail ci if Coverage reporting fails#1244
maxreichmann wants to merge 1 commit intomainfrom
ci/do-not-fail-ci-on-coveralls-downtimes

Conversation

@maxreichmann
Copy link
Copy Markdown
Member

As seen in this GH Actions run, the Coveralls servers can be down very easily.

This adds continue-on-error to the coverage upload step too (previously only on coverage calculation steps)

…s are down)

This adds `continue-on-error` to the coverage upload step too (previously only on coverage calculation steps)
@maxreichmann maxreichmann requested review from a team and RandomByte December 11, 2025 15:23
Comment thread .github/workflows/coverage.yml
@maxreichmann
Copy link
Copy Markdown
Member Author

Outcome of discussion (Dec 15, @d3xter666 & @maxreichmann):

Since we don't want to miss if the Coverage actually went down and get notified about it, the approach is as follows:
We're keeping the flag for the parallel steps ("Coverage / Check and Upload (packages/...)") and not adding it to the upload step ("Coverage / finish"). When the servers are up, we can see the coverage percentage without problems. When the servers are down, we can easily calculate the coverage locally and are still be able to merge.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants