Open
Conversation
* Add "e2e-tests" dir under "internal/" * Add tests for following community custom tasks: - ui5-tooling-transpile - ui5-task-zipper - ui5-tooling-modules - ui5-tooling-stringreplace * Add test for "ui5 --version"
Member
Author
|
@UI5/ui5-team-cor-fnd These tests are not included in any CI pipeline yet. It's up for debate if we want to include them. |
d3xter666
requested changes
Apr 9, 2026
Member
d3xter666
left a comment
d3xter666
left a comment
There was a problem hiding this comment.
There's also an e2e test setup in packages/cli.
Can we leverage and consolidate the setup from there?
Or simply clean it up if it's redundant an too complex anymore?
| test("ui5-tooling-transpile", async ({assert}) => { | ||
| const fixtureHelper = new FixtureHelper("application.a.ts"); | ||
| await fixtureHelper.init(); | ||
| process.env.UI5_DATA_DIR = `${fixtureHelper.dotUi5Path}`; |
Member
There was a problem hiding this comment.
This is manipulated globally and is not cleaned up.
A cleanup in before/after pahse is needed.
| const fixtureHelper = new FixtureHelper("application.a.ts"); | ||
| await fixtureHelper.init(); | ||
| process.env.UI5_DATA_DIR = `${fixtureHelper.dotUi5Path}`; | ||
| process.chdir(fixtureHelper.tmpPath); |
Member
There was a problem hiding this comment.
This changes the directory and is not reset later
maxreichmann
force-pushed
the
test/e2e-tests
branch
from
c12b05a to
1e7aace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outsourced of Incremental Build PR #1267:
All tests are currently passing (April 8th).