-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Clean cache command #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d3xter666
wants to merge
20
commits into
main
Choose a base branch
from
feat-clean-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9bcacaf
feat: Clean cache command
d3xter666 d49b45d
refactor: Use single place for DB manipulation
d3xter666 c64092a
refactor: Simplify cache clean
d3xter666 30df6b5
refactor: Position correctly the CacheCleanup
d3xter666 7318ffe
refactor: Add confirmation dialog for the cache clean command
d3xter666 0320c6f
refactor: Rename cacheVersionDir
d3xter666 b0c9252
refactor: Restore location of CacheCleanup
d3xter666 dc168dc
fix: Clean only current cache version
d3xter666 becc3a8
refactor: Simplify CacheCleanup
d3xter666 c958891
test: Improve coverage
d3xter666 36fd376
refactor: CLI package orchestrates cache cleanup
d3xter666 c1eb38c
refactor: Add skip confirmation option
d3xter666 48aafe9
fix: Windows paths for tests
d3xter666 1c161bb
refactor: Use yesno package for CLI confirmation
d3xter666 2631451
refactor: Simplify cleanup meta structure
d3xter666 1ade6fd
fix: Add guard to not accidently create a new DB
d3xter666 8a53eb8
refactor: Reuse meta from installers in cache cleanup
d3xter666 fd604cd
refactor: Cleanup details
d3xter666 9c81ede
fix: Respect datadir config
d3xter666 8172c6f
docs: Update cache clean --help CLI information
d3xter666 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| import chalk from "chalk"; | ||
| import path from "node:path"; | ||
| import os from "node:os"; | ||
| import process from "node:process"; | ||
| import baseMiddleware from "../middlewares/base.js"; | ||
| import {getUi5DataDir} from "../../framework/utils.js"; | ||
| import * as frameworkCache from "@ui5/project/ui5Framework/cache"; | ||
| import CacheManager from "@ui5/project/build/cache/CacheManager"; | ||
|
|
||
| const cacheCommand = { | ||
| command: "cache", | ||
| describe: "Manage the UI5 CLI cache (downloaded framework packages and incremental build data)", | ||
| middlewares: [baseMiddleware], | ||
| handler: handleCache | ||
| }; | ||
|
|
||
| cacheCommand.builder = function(cli) { | ||
| return cli | ||
| .demandCommand(1, "Command required. Available command is 'clean'") | ||
| .command("clean", "Remove all cached UI5 data", { | ||
| handler: handleCache, | ||
| builder: function(yargs) { | ||
| return yargs | ||
| .option("yes", { | ||
| alias: "y", | ||
| describe: "Skip the confirmation prompt, e.g. for use in CI pipelines", | ||
| default: false, | ||
| type: "boolean", | ||
| }) | ||
| .example("$0 cache clean", | ||
| "Remove all cached UI5 data after confirming the prompt") | ||
| .example("$0 cache clean --yes", | ||
| "Remove all cached UI5 data without confirmation (e.g. in CI)") | ||
| .example("UI5_DATA_DIR=/custom/path $0 cache clean", | ||
| "Remove cached data from a non-default UI5 data directory"); | ||
| }, | ||
| middlewares: [baseMiddleware], | ||
| }); | ||
| }; | ||
|
|
||
| const LABEL_FRAMEWORK = "UI5 Framework packages"; | ||
| const LABEL_BUILD = "Build cache (DB)"; | ||
| // Pad labels to equal width for two-column alignment | ||
| const LABEL_WIDTH = Math.max(LABEL_FRAMEWORK.length, LABEL_BUILD.length); | ||
|
|
||
| /** | ||
| * Format a byte size as a human-readable string. | ||
| * | ||
| * @param {number} bytes Size in bytes | ||
| * @returns {string} Formatted size string | ||
| */ | ||
| function formatSize(bytes) { | ||
| if (bytes < 1024) { | ||
| return `${bytes} B`; | ||
| } else if (bytes < 1024 * 1024) { | ||
| return `${(bytes / 1024).toFixed(1)} KB`; | ||
| } else if (bytes < 1024 * 1024 * 1024) { | ||
| return `${(bytes / (1024 * 1024)).toFixed(1)} MB`; | ||
| } | ||
| return `${(bytes / (1024 * 1024 * 1024)).toFixed(1)} GB`; | ||
| } | ||
|
|
||
| /** | ||
| * Format a count with its singular/plural word, e.g. "340 files" or "1 file". | ||
| * | ||
| * @param {number} count | ||
| * @returns {string} | ||
| */ | ||
| function formatFileCount(count) { | ||
| return `${count} ${count === 1 ? "file" : "files"}`; | ||
| } | ||
|
|
||
| /** | ||
| * Pad a label to the shared column width. | ||
| * | ||
| * @param {string} label | ||
| * @returns {string} | ||
| */ | ||
| function padLabel(label) { | ||
| return label.padEnd(LABEL_WIDTH); | ||
| } | ||
|
|
||
| async function handleCache(argv) { | ||
| // Resolve UI5 data directory — uses the same resolution chain as ui5 build/serve: | ||
| // UI5_DATA_DIR env var → ui5DataDir config (~/.ui5rc) → default ~/.ui5 | ||
| // Relative paths are resolved against process.cwd() (project root when invoked from the project). | ||
| const ui5DataDir = | ||
| (await getUi5DataDir({cwd: process.cwd()})) ?? path.join(os.homedir(), ".ui5"); | ||
|
|
||
| // Abort early if a framework operation is holding a lock — before prompting the user | ||
| if (await frameworkCache.isFrameworkLocked(ui5DataDir)) { | ||
| process.stderr.write( | ||
| `${chalk.red("Error:")} Framework cache is currently locked by an active operation. ` + | ||
| "Please wait for it to finish and try again.\n" | ||
| ); | ||
| process.exitCode = 1; | ||
| return; | ||
| } | ||
|
|
||
| // Inform the user immediately — getCacheInfo (especially countFiles) may take a moment | ||
| process.stderr.write(`Checking cache at ${chalk.bold(ui5DataDir)} …\n`); | ||
|
|
||
| // Check what items exist before cleaning (orchestrate both domains) | ||
| const frameworkInfo = await frameworkCache.getCacheInfo(ui5DataDir); | ||
| const buildInfo = await CacheManager.getCacheInfo(ui5DataDir); | ||
|
|
||
| if (!frameworkInfo && !buildInfo) { | ||
| process.stderr.write("Nothing to clean\n"); | ||
| return; | ||
| } | ||
|
|
||
| // Compute absolute paths once — producers return relative sub-path segments | ||
| const frameworkAbsPath = frameworkInfo ? path.join(ui5DataDir, frameworkInfo.path) : null; | ||
| const buildAbsPath = buildInfo ? path.join(ui5DataDir, buildInfo.path) : null; | ||
|
|
||
| // Capture build size now — reused for the ✓ line to avoid a before/after mismatch | ||
| // (getDatabaseSize ≠ VACUUM-freed bytes returned by clearAllRecords) | ||
| const buildPreSize = buildInfo?.size ?? 0; | ||
|
|
||
| // Display items that will be removed | ||
| process.stderr.write(chalk.bold("\nThe following cached data will be removed:\n\n")); | ||
| if (frameworkInfo) { | ||
| const detail = formatFileCount(frameworkInfo.count); | ||
| process.stderr.write( | ||
| ` ${chalk.yellow("•")} ${padLabel(LABEL_FRAMEWORK)} ${frameworkAbsPath} (${detail})\n` | ||
| ); | ||
| } | ||
| if (buildInfo) { | ||
| const detail = buildPreSize > 0 ? formatSize(buildPreSize) : ""; | ||
| process.stderr.write( | ||
| ` ${chalk.yellow("•")} ${padLabel(LABEL_BUILD)} ${buildAbsPath} (${detail})\n` | ||
| ); | ||
| } | ||
| process.stderr.write("\n"); | ||
|
|
||
| // Ask for confirmation (skip with --yes) | ||
| if (!argv.yes) { | ||
| const {default: yesno} = await import("yesno"); | ||
| const confirmed = await yesno({ | ||
| question: "Do you want to continue? (y/N)", | ||
| defaultValue: false | ||
| }); | ||
| if (!confirmed) { | ||
| process.stderr.write("Cancelled\n"); | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| // Perform the actual cleanup (orchestrate both domains) | ||
| const frameworkResult = await frameworkCache.cleanCache(ui5DataDir); | ||
| const buildResult = await CacheManager.cleanCache(ui5DataDir); | ||
|
|
||
| process.stderr.write("\n"); | ||
| if (frameworkResult) { | ||
| const detail = formatFileCount(frameworkResult.count); | ||
| process.stderr.write( | ||
| `${chalk.green("✓")} Removed ${chalk.bold(LABEL_FRAMEWORK)}` + | ||
| ` (${frameworkAbsPath} · ${detail})\n` | ||
| ); | ||
| } | ||
| if (buildResult) { | ||
| // Use pre-clean size so the number matches what was shown before confirmation | ||
| const detail = buildPreSize > 0 ? formatSize(buildPreSize) : ""; | ||
| process.stderr.write( | ||
| `${chalk.green("✓")} Removed ${chalk.bold(LABEL_BUILD)}` + | ||
| ` (${buildAbsPath}${detail ? ` · ${detail}` : ""})\n` | ||
| ); | ||
| } | ||
|
|
||
| // Success summary | ||
| const cleaned = []; | ||
| if (frameworkResult) { | ||
| cleaned.push(LABEL_FRAMEWORK); | ||
| } | ||
| if (buildResult) { | ||
| cleaned.push(LABEL_BUILD); | ||
| } | ||
| process.stderr.write(`\n${chalk.green("Success:")} Cleaned ${cleaned.join(" and ")}\n`); | ||
| } | ||
|
|
||
| export default cacheCommand; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.