docs: Add agent skills#1040
Conversation
|
I validated the create-rule skill with a change created by the agent and one inconsistency between the existing tests and the skill is found:
|
RandomByte
force-pushed
the
docs/add-agent-skills
branch
from
583725a to
6ff9a7b
Compare
d3xter666
left a comment
d3xter666
left a comment
There was a problem hiding this comment.
LGTM
Just one small remark:
Symlinks for .claude/skills might not work in some environments.
For the agents plugin we simply copy the skills during the build phase
I saw this practice in other projects, e.g. https://github.com/NVIDIA/OpenShell/blob/main/.claude/skills Also https://github.com/vercel-labs/skills#installation-methods seems to work with symlinks by default. Let me know if you face any issues with one of your tools! |
| - `FirstChild` - When replacing `Config.getTheme()` with `Theming.getTheme()` (same args) | ||
| - `SecondChild` - When replacing `Config.setRTL(val)` with `Localization.setRTL(val)` and the Config access needs to be replaced but the method name stays |
There was a problem hiding this comment.
I don't really see a difference between the two examples here. Maybe the examples can be updated to better show how they differ?
| **Run the autofix tests:** | ||
|
|
||
| ```bash | ||
| npm run unit -- test/lib/autofix/autofix.projects.ts |
There was a problem hiding this comment.
I think this should be test/lib/autofix/autofix.fixtures.ts.
autofix.projects.ts runs the fixture projects from fixtures/linter/projects, not fixtures/autofix.
| **Update snapshots:** | ||
|
|
||
| ```bash | ||
| npm run unit-update-snapshots -- test/lib/autofix/autofix.projects.ts |
There was a problem hiding this comment.
Same here, and in the snapshots below.
| test/fixtures/linter/rules/$0/ | ||
| Positive_1/ # Code that SHOULD trigger the rule | ||
| webapp/ | ||
| Component.js # (or whatever files are relevant) | ||
| manifest.json # (include if needed by the check) | ||
| Negative_1/ # Code that should NOT trigger the rule | ||
| webapp/ | ||
| Component.js | ||
| manifest.json |
There was a problem hiding this comment.
The dir-based testing based on projects currently only works for AsyncComponentFlags and renderer (see if-clause in test/lib/linter/_linterHelper.ts#createTestsForFixtures).
In all other cases, the code will lint each file one by one (isolated).
| @@ -0,0 +1,146 @@ | |||
| # CLAUDE.md | |||
| - `docs/Scope-of-Autofix.md` - Lists APIs that cannot be replaced automatically and why | ||
| - `docs/Development.md` - Development guidelines and autofix implementation checklist | ||
|
|
||
| ## Autofix Development |
There was a problem hiding this comment.
Refer to the skill here? But as skills are "visible" to agents anyways, maybe this can be completely removed.
4 participants
No description provided.