test: Resolve failing tests

Author: dimovpetar

src/tools/create_integration_card/create_integration_card.ts

@@ -15,7 +15,7 @@ interface CreateIntegrationCardParams {
 	folderPath: string;
 	cardType: SupportedCardType;
 	manifestVersion: string;
-	destinations: Destination[];
+	destinations?: Destination[];
 };
 
 export async function createIntegrationCard({

src/tools/create_integration_card/schema.ts

@@ -11,6 +11,13 @@ export const supportedCardTypes = [
 
 export type SupportedCardType = typeof supportedCardTypes[number];
 
+const destinationSchema = z.object({
+	name: z.string().describe("Name of the destination."),
+	defaultUrl: z.url().describe("Default URL of the destination."),
+});
+
+export type Destination = z.infer<typeof destinationSchema>;
+
 export const inputSchema = {
 	basePath: z.string()
 		.describe("Absolute base path for the creation."),
@@ -20,11 +27,7 @@ export const inputSchema = {
 	cardType: z.enum(supportedCardTypes)
 		.describe("Type of the Integration Card to create.")
 		.default("List"),
-	destinations: z.array(z.object({
-		name: z.string().describe("Name of the destination."),
-		defaultUrl: z.url().describe("Default URL of the destination."),
-	})).describe("List of destinations to be included in the card configuration.")
-		.default([]),
+	destinations: z.array(destinationSchema)
+		.describe("List of destinations to be included in the card configuration.")
+		.optional(),
 };
-
-export type Destination = z.infer<typeof inputSchema.destinations>[number];

test/expected/create_integration_card/common/test/App.js

@@ -7,13 +7,16 @@ sap.ui.define(["sap/ui/integration/Host"], async (Host) => {
 	const card = document.getElementById("card");
 	const applyChangesBtn = document.getElementById("applyChangesBtn");
 	const resetBtn = document.getElementById("resetBtn");
+	const destinations = {
+		Northwind: "https://services.odata.org/V4/Northwind/Northwind.svc/"
+	};
 	const host = new Host({
 		resolveDestination: function(sDestinationName) {
-			if (sDestinationName === "Northwind") {
-				return "https://services.odata.org/V4/Northwind/Northwind.svc/";
+			if (destinations[sDestinationName]) {
+				return destinations[sDestinationName];
 			}
 
-			throw new Error("Destination " + sDestinationName + " not found!");
+			return Promise.reject("Destination " + sDestinationName + " not found!");
 		},
 		actions: [
 			{
@@ -27,6 +30,15 @@ sap.ui.define(["sap/ui/integration/Host"], async (Host) => {
 		]
 	});
 
+	// Called by the Configuration Editor to show a list of available destinations
+	host.getDestinations = function() {
+		return Promise.resolve(Object.entries(destinations).map(([name, url]) => {
+			return {
+				name,
+			};
+		}));
+	};
+
 	card.host = host.getId();
 	card.manifest = "../card/manifest.json";
 

test/expected/create_integration_card/common/test/index.css

@@ -17,6 +17,10 @@ body {
 	flex-direction: column;
 }
 
+.editor-section {
+	--sapUiIntegrationEditorFormHeight: auto;
+}
+
 .button-container {
 	display: flex;
 	justify-content: flex-end;

test/lib/tools/create_integration_card/create_integration_card.integration.ts

@@ -77,7 +77,6 @@ supportedCardTypes.forEach((cardType) => {
 			folderPath,
 			cardType,
 			manifestVersion: "1.78.0",
-			destinations: [],
 		});
 		// Normalize paths for snapshot consistency across OSes
 		const normalizedResult = result.map((filePath) => filePath.replaceAll(path.sep, "/")).sort();

test/lib/tools/create_integration_card/create_integration_card.ts

@@ -110,7 +110,7 @@ test("createIntegrationCard executes successfully", async (t) => {
 		folderPath,
 		cardType: "List",
 		manifestVersion: "1.78.0",
-		destinations: [],
+		destinations: undefined,
 	});
 
 	t.is(mkdirStub.callCount, 4);
@@ -135,6 +135,7 @@ test("createIntegrationCard executes successfully", async (t) => {
 		t.deepEqual(templateVars, {
 			cardType: "List",
 			manifestVersion: "1.78.0",
+			destinations: undefined,
 		});
 	});
 
@@ -154,7 +155,6 @@ test("Target path already exists", async (t) => {
 			folderPath,
 			cardType: "List",
 			manifestVersion: "1.78.0",
-			destinations: [],
 		});
 	}, {
 		message:
@@ -177,7 +177,6 @@ test("Error creating target directory", async (t) => {
 			folderPath,
 			cardType: "List",
 			manifestVersion: "1.78.0",
-			destinations: [],
 		});
 	}, {
 		message:
@@ -201,7 +200,6 @@ test("Invalid manifest version", async (t) => {
 			folderPath,
 			cardType: "List",
 			manifestVersion: invalidManifestVersion,
-			destinations: [],
 		});
 	}, {
 		message: "The provided manifest version is not valid!",
@@ -220,7 +218,6 @@ test("Error processing template file", async (t) => {
 			folderPath,
 			cardType: "List",
 			manifestVersion: "1.78.0",
-			destinations: [],
 		});
 	}, {
 		message: `Failed to process template file 'card/manifest.json': ${errorMessage}`,

test/lib/tools/create_integration_card/index.ts

@@ -78,6 +78,7 @@ test("create_integration_card tool returns success message on success", async (t
 		folderPath: "/projects/mycards/mycard".replace(/\//g, path.sep),
 		cardType: "List",
 		manifestVersion: "1.78.0",
+		destinations: undefined,
 	}]);
 
 	const message = `Successfully created Integration Card ${params.cardFolderName} at ${params.basePath}\n` +