feat(Integration Cards): Improve generation of Configuration Editor#204
Closed
dimovpetar wants to merge 0 commit into
Closed
feat(Integration Cards): Improve generation of Configuration Editor#204dimovpetar wants to merge 0 commit into
dimovpetar wants to merge 0 commit into
Conversation
dimovpetar
force-pushed
the
feat_config_editor
branch
2 times, most recently
from
90c4ef4 to
dfedd53
Compare
alexandar-mitsev
suggested changes
Feb 3, 2026
Member
alexandar-mitsev
left a comment
alexandar-mitsev
left a comment
There was a problem hiding this comment.
- addition in destinations seems to work well. It can be merged
- configuration editor is not improved much, but the guidelines can be merged at that stage and we can think what we can do further
| - **ALWAYS** make the existing fields in the `manifest.json` configurable via the editor. For example manifest parameters, title, subtitle, icon of the header, etc. | ||
| - **NEVER** add fields to the editor that do not exist in the `manifest.json`. | ||
| - **ALWAYS** remove fields from the editor when removing them from the `manifest.json`. | ||
| - **ALWAYS** add fields in the Configuration Editor when adding them to the `manifest.json`. |
Member
There was a problem hiding this comment.
- add explanation that Configuration.js is the file which holds instructions for the configuration editor
In general the effect of this instructions is not so strong.
- maybe it is worth it to add to the template common parameters , e.g. maxItems and show how they are used inside the card
- should we consider a separate tool for this? Maybe worth experimenting.
Member
Author
There was a problem hiding this comment.
- Explanation is added
- the template already has
titleandsubtitleconfigurable - this should be discussed
dimovpetar
force-pushed
the
feat_config_editor
branch
2 times, most recently
from
c3cd5e1 to
b2ed707
Compare
dimovpetar
force-pushed
the
feat_config_editor
branch
from
b2ed707 to
029d376
Compare
Member
Author
|
continued in #230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.