feat(Integration Cards): Improve generation of Configuration Editor

[dimovpetar]

No description provided.

[flovogt]

@akudev @RandomByte Could you please do a review?

[RandomByte]

Unless I'm misunderstanding the implications of this change, it seems similar to the standard create_ui5_app tool, where the LLM can provide arbitrary OData Service endpoints.

For create_ui5_app we introduced a configurable allow-list of OData domains: UI5_MCP_SERVER_ALLOWED_ODATA_DOMAINS. See implementation:

mcp-server/src/tools/create_ui5_app/create_ui5_app.ts

Lines 89 to 90 in 3e49ef3

	const allowedDomains = getAllowedOdataV4Domains();
	if (!isValidUrl(metadataUrl, allowedDomains)) {

I think we should do the same here for consistency and security reasons.

[dimovpetar]

Unless I'm misunderstanding the implications of this change, it seems similar to the standard create_ui5_app tool, where the LLM can provide arbitrary OData Service endpoints.

For create_ui5_app we introduced a configurable allow-list of OData domains: UI5_MCP_SERVER_ALLOWED_ODATA_DOMAINS. See implementation:

mcp-server/src/tools/create_ui5_app/create_ui5_app.ts

Lines 89 to 90 in 3e49ef3

	const allowedDomains = getAllowedOdataV4Domains();
	if (!isValidUrl(metadataUrl, allowedDomains)) {

I think we should do the same here for consistency and security reasons.

Done.
I will rename the environment variable and refactor related code in another PR.

[coveralls]

Pull Request Test Coverage Report for Build 22131687830

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 19 of 23 (82.61%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.06%) to 82.488%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/tools/create_integration_card/create_integration_card.ts	4	8	50.0%

Totals
Change from base Build 22104956914:	-0.06%
Covered Lines:	1154
Relevant Lines:	1302

---

💛 - Coveralls

[RandomByte]

Thanks!