Skip to content

Commit b0265c3

Browse files
committed
fix(test): Update all references from ui5-guidelines to ui5 after migration
- Update plugin path: ~/.claude/plugins/ui5-guidelines → ~/.claude/plugins/ui5 - Update environment variable: CLAUDE_PLUGINS="ui5-guidelines" → CLAUDE_PLUGINS="ui5" - Update all documentation references - Remove typo directory (u5-guidelines) This completes the migration to the consolidated ui5 plugin structure.
1 parent 7af8835 commit b0265c3

16 files changed

Lines changed: 59 additions & 80 deletions

plugins/u5-guidelines/skill-test-framework/tsconfig.json

Lines changed: 0 additions & 21 deletions
This file was deleted.

plugins/ui5/INTEGRATION_TESTS.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ Integration tests validate real Claude behavior using the Claude Code CLI. Unlik
2020

2121
### Optional
2222

23-
- Plugin symlinked to `~/.claude/plugins/ui5-guidelines`
24-
- Environment variable: `CLAUDE_PLUGINS="ui5-guidelines"`
23+
- Plugin symlinked to `~/.claude/plugins/ui5`
24+
- Environment variable: `CLAUDE_PLUGINS="ui5"`
2525

2626
---
2727

@@ -30,7 +30,7 @@ Integration tests validate real Claude behavior using the Claude Code CLI. Unlik
3030
### Full Test Suite
3131

3232
```bash
33-
cd plugins/ui5-guidelines
33+
cd plugins/ui5
3434
npm run test:integration:claude
3535
```
3636

@@ -164,7 +164,7 @@ Default: 60 seconds per test
164164

165165
### Environment
166166

167-
Tests set `CLAUDE_PLUGINS="ui5-guidelines"` to ensure only the target plugin is loaded.
167+
Tests set `CLAUDE_PLUGINS="ui5"` to ensure only the target plugin is loaded.
168168

169169
### Stdin Handling
170170

@@ -413,12 +413,12 @@ jobs:
413413
414414
- name: Install dependencies
415415
run: |
416-
cd plugins/ui5-guidelines
416+
cd plugins/ui5
417417
npm install
418418
419419
- name: Run integration tests
420420
run: |
421-
cd plugins/ui5-guidelines
421+
cd plugins/ui5
422422
npm run build
423423
npm run test:integration:claude
424424
```

plugins/ui5/INTEGRATION_TEST_FINDINGS.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Integration tests successfully validate that:
66
1. ✅ Claude Code CLI is properly configured with plugin support
7-
2. ✅ ui5-guidelines plugin can be loaded via `CLAUDE_PLUGINS` environment variable
7+
2. ✅ ui5 plugin can be loaded via `CLAUDE_PLUGINS` environment variable
88
3. ✅ Extended thinking compatibility issue identified and fixed
99
4. ⚠️ Skill triggering rate: 40% (8/20 tests), with 35% failures and 25% timeouts
1010

@@ -28,7 +28,7 @@ Set `MAX_THINKING_TOKENS=0` environment variable to disable extended thinking:
2828
const child = spawn("claude", [prompt], {
2929
env: {
3030
...process.env,
31-
CLAUDE_PLUGINS: "ui5-guidelines",
31+
CLAUDE_PLUGINS: "ui5",
3232
MAX_THINKING_TOKENS: "0", // Disable extended thinking
3333
},
3434
stdio: ['ignore', 'pipe', 'pipe'],
@@ -38,7 +38,7 @@ const child = spawn("claude", [prompt], {
3838
### Verification
3939
Manual test confirmed fix works:
4040
```bash
41-
CLAUDE_PLUGINS="ui5-guidelines" MAX_THINKING_TOKENS=0 claude "Show me how to use sap.ui.define"
41+
CLAUDE_PLUGINS="ui5" MAX_THINKING_TOKENS=0 claude "Show me how to use sap.ui.define"
4242
# ✅ Works correctly - returns UI5 response with proper UI5 patterns
4343
```
4444

@@ -53,20 +53,20 @@ Tests assumed plugin was installed but never verified it, leading to unclear fai
5353
Added pre-flight check in `test.before()`:
5454

5555
```typescript
56-
const pluginPath = join(homedir(), '.claude', 'plugins', 'ui5-guidelines');
56+
const pluginPath = join(homedir(), '.claude', 'plugins', 'ui5');
5757
pluginInstalled = existsSync(pluginPath);
5858

5959
if (!pluginInstalled) {
60-
console.warn("\n⚠️ ui5-guidelines plugin not installed");
60+
console.warn("\n⚠️ ui5 plugin not installed");
6161
console.warn(` Expected at: ${pluginPath}`);
62-
console.warn(" Run: ln -s $(pwd) ~/.claude/plugins/ui5-guidelines");
62+
console.warn(" Run: ln -s $(pwd) ~/.claude/plugins/ui5");
6363
}
6464
```
6565

6666
### Output
6767
```
6868
✅ Claude Code CLI available
69-
✅ Plugin installed at: /Users/i326076/.claude/plugins/ui5-guidelines
69+
✅ Plugin installed at: /Users/i326076/.claude/plugins/ui5
7070
🚀 Running integration tests...
7171
```
7272

@@ -115,10 +115,10 @@ if (!pluginInstalled) {
115115
## How Skill Loading is Verified
116116

117117
### 1. Plugin Installation Check
118-
Before running tests, verify plugin exists at `~/.claude/plugins/ui5-guidelines`
118+
Before running tests, verify plugin exists at `~/.claude/plugins/ui5`
119119

120120
### 2. Environment Variable
121-
Set `CLAUDE_PLUGINS="ui5-guidelines"` to ensure only target plugin is loaded
121+
Set `CLAUDE_PLUGINS="ui5"` to ensure only target plugin is loaded
122122

123123
### 3. Skill Detection (Heuristic)
124124
Tests detect skill usage by looking for 2+ UI5-specific patterns in response:
@@ -161,7 +161,7 @@ Tests failed NOT because skill didn't respond, but because:
161161

162162
### 4. Environment Configuration Working ✅
163163
- Plugin installation verified before tests
164-
- `CLAUDE_PLUGINS="ui5-guidelines"` set correctly
164+
- `CLAUDE_PLUGINS="ui5"` set correctly
165165
- `MAX_THINKING_TOKENS=0` fixed extended thinking issue
166166
- Tests run in clean environment
167167

@@ -198,7 +198,7 @@ Tests failed NOT because skill didn't respond, but because:
198198
### Environment Variables Set
199199
```typescript
200200
{
201-
CLAUDE_PLUGINS: "ui5-guidelines", // Enable only target plugin
201+
CLAUDE_PLUGINS: "ui5", // Enable only target plugin
202202
MAX_THINKING_TOKENS: "0", // Disable extended thinking (required!)
203203
}
204204
```
@@ -213,7 +213,7 @@ Tests failed NOT because skill didn't respond, but because:
213213

214214
Integration tests successfully validate that:
215215
1. ✅ Plugin infrastructure works correctly
216-
2. ✅ Claude can access and use the ui5-guidelines skill
216+
2. ✅ Claude can access and use the ui5 skill
217217
3. ✅ Skill provides accurate UI5 guidance when triggered
218218
4. ⚠️ Skill triggering is not 100% reliable (40% detection rate)
219219
5. ⚠️ Heuristic detection has limitations

plugins/ui5/INTEGRATION_TEST_IMPROVEMENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ async function testWithAPI(prompt: string) {
314314
const message = await anthropic.messages.create({
315315
model: 'claude-sonnet-4-6',
316316
max_tokens: 4096,
317-
tools: [/* ui5-guidelines tool definition */],
317+
tools: [/* ui5 tool definition */],
318318
messages: [{ role: 'user', content: prompt }],
319319
});
320320

plugins/ui5/INTEGRATION_TEST_SUMMARY.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ Successfully identified, documented, and partially implemented solutions to impr
1313
### Answer: 4-Layer Verification
1414

1515
1. **Plugin Installation Check**
16-
- Tests verify plugin exists at `~/.claude/plugins/ui5-guidelines`
16+
- Tests verify plugin exists at `~/.claude/plugins/ui5`
1717
- Pre-flight check before running any tests
1818
- Clear status messages displayed
1919

2020
2. **Environment Configuration**
21-
- `CLAUDE_PLUGINS="ui5-guidelines"` ensures only target plugin loads
21+
- `CLAUDE_PLUGINS="ui5"` ensures only target plugin loads
2222
- `MAX_THINKING_TOKENS=0` fixes extended thinking incompatibility
2323
- Clean environment per test
2424

@@ -34,7 +34,7 @@ Successfully identified, documented, and partially implemented solutions to impr
3434
### Output
3535
```
3636
✅ Claude Code CLI available
37-
✅ Plugin installed at: /Users/i326076/.claude/plugins/ui5-guidelines
37+
✅ Plugin installed at: /Users/i326076/.claude/plugins/ui5
3838
🚀 Running integration tests...
3939
```
4040

plugins/ui5/PHASE_3.2_COMPLETE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ TEST_VERBOSE=1 npm run test:integration
122122

123123
🔍 Test: "What inline content violates CSP in UI5?"
124124
⏱️ Start time: 2026-05-18T10:30:45.000Z
125-
🔌 Environment: CLAUDE_PLUGINS=ui5-guidelines
125+
🔌 Environment: CLAUDE_PLUGINS=ui5
126126
⏰ Timeout: 120000ms
127127

128128
# ... test runs ...

plugins/ui5/PHASE_3.3_COMPLETE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ npm run test:integration
123123
**Output**:
124124
```
125125
✅ Claude Code CLI available
126-
✅ Plugin installed at: /Users/.../.claude/plugins/ui5-guidelines
126+
✅ Plugin installed at: /Users/.../.claude/plugins/ui5
127127
🚀 Running integration tests...
128128
129129
[... tests run ...]

plugins/ui5/PHASE_4_CORE_COMPLETE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,14 @@ const runner = new TestRunner(evaluator);
146146
runner.registerAgent(new ClaudeCodeAdapter({ verbose: true }));
147147

148148
// 4. Load skill
149-
await runner.loadSkill('/path/to/ui5-guidelines');
149+
await runner.loadSkill('/path/to/ui5');
150150

151151
// 5. Define test suite
152152
const suite: TestSuite = {
153153
id: 'ui5-integration',
154154
name: 'UI5 Best Practices Integration Tests',
155155
description: 'Test UI5 skill with real Claude',
156-
skillPath: '/path/to/ui5-guidelines',
156+
skillPath: '/path/to/ui5',
157157
testCases: [
158158
{
159159
id: '1',

plugins/ui5/TESTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ The UI5 Guidelines plugin has a **three-level testing approach** to ensure quali
1919
**Purpose**: Fast, deterministic validation of plugin configuration and file structure.
2020

2121
**What it tests**:
22-
- ✅ Plugin metadata validation ([plugin.json](plugins/ui5-guidelines/.claude-plugin/plugin.json))
22+
- ✅ Plugin metadata validation ([plugin.json](plugins/ui5/.claude-plugin/plugin.json))
2323
- ✅ Skill file existence and structure
2424
- ✅ YAML frontmatter validity
2525
- ✅ Skill token budget (warning at 700 lines, current: ~510 lines)
@@ -120,7 +120,7 @@ npm run test:triggering # Simulated keyword matching
120120

121121
**Run**:
122122
```bash
123-
cd plugins/ui5-guidelines
123+
cd plugins/ui5
124124
npm run test:integration:claude
125125
```
126126

@@ -192,7 +192,7 @@ const tokensUsed = Math.ceil((prompt.length + response.length) / 4);
192192

193193
**Timeout**: Default 90 seconds per test (configurable via `TEST_TIMEOUT` env var)
194194

195-
**Environment**: Tests set `CLAUDE_PLUGINS="ui5-guidelines"` to ensure only the target plugin is loaded
195+
**Environment**: Tests set `CLAUDE_PLUGINS="ui5"` to ensure only the target plugin is loaded
196196

197197
**Stdin Handling**: Uses `spawn` with `stdio: ['ignore', 'pipe', 'pipe']` to prevent "waiting for stdin" timeouts
198198

@@ -238,7 +238,7 @@ const tokensUsed = Math.ceil((prompt.length + response.length) / 4);
238238
### Quick Start
239239

240240
```bash
241-
cd plugins/ui5-guidelines
241+
cd plugins/ui5
242242
npm install
243243
npm run build
244244

plugins/ui5/docs/INTEGRATION_TEST_FINDINGS.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Integration tests successfully validate that:
66
1. ✅ Claude Code CLI is properly configured with plugin support
7-
2. ✅ ui5-guidelines plugin can be loaded via `CLAUDE_PLUGINS` environment variable
7+
2. ✅ ui5 plugin can be loaded via `CLAUDE_PLUGINS` environment variable
88
3. ✅ Extended thinking compatibility issue identified and fixed
99
4. ⚠️ Skill triggering rate: 40% (8/20 tests), with 35% failures and 25% timeouts
1010

@@ -28,7 +28,7 @@ Set `MAX_THINKING_TOKENS=0` environment variable to disable extended thinking:
2828
const child = spawn("claude", [prompt], {
2929
env: {
3030
...process.env,
31-
CLAUDE_PLUGINS: "ui5-guidelines",
31+
CLAUDE_PLUGINS: "ui5",
3232
MAX_THINKING_TOKENS: "0", // Disable extended thinking
3333
},
3434
stdio: ['ignore', 'pipe', 'pipe'],
@@ -38,7 +38,7 @@ const child = spawn("claude", [prompt], {
3838
### Verification
3939
Manual test confirmed fix works:
4040
```bash
41-
CLAUDE_PLUGINS="ui5-guidelines" MAX_THINKING_TOKENS=0 claude "Show me how to use sap.ui.define"
41+
CLAUDE_PLUGINS="ui5" MAX_THINKING_TOKENS=0 claude "Show me how to use sap.ui.define"
4242
# ✅ Works correctly - returns UI5 response with proper UI5 patterns
4343
```
4444

@@ -53,20 +53,20 @@ Tests assumed plugin was installed but never verified it, leading to unclear fai
5353
Added pre-flight check in `test.before()`:
5454

5555
```typescript
56-
const pluginPath = join(homedir(), '.claude', 'plugins', 'ui5-guidelines');
56+
const pluginPath = join(homedir(), '.claude', 'plugins', 'ui5');
5757
pluginInstalled = existsSync(pluginPath);
5858

5959
if (!pluginInstalled) {
60-
console.warn("\n⚠️ ui5-guidelines plugin not installed");
60+
console.warn("\n⚠️ ui5 plugin not installed");
6161
console.warn(` Expected at: ${pluginPath}`);
62-
console.warn(" Run: ln -s $(pwd) ~/.claude/plugins/ui5-guidelines");
62+
console.warn(" Run: ln -s $(pwd) ~/.claude/plugins/ui5");
6363
}
6464
```
6565

6666
### Output
6767
```
6868
✅ Claude Code CLI available
69-
✅ Plugin installed at: /Users/i326076/.claude/plugins/ui5-guidelines
69+
✅ Plugin installed at: /Users/i326076/.claude/plugins/ui5
7070
🚀 Running integration tests...
7171
```
7272

@@ -115,10 +115,10 @@ if (!pluginInstalled) {
115115
## How Skill Loading is Verified
116116

117117
### 1. Plugin Installation Check
118-
Before running tests, verify plugin exists at `~/.claude/plugins/ui5-guidelines`
118+
Before running tests, verify plugin exists at `~/.claude/plugins/ui5`
119119

120120
### 2. Environment Variable
121-
Set `CLAUDE_PLUGINS="ui5-guidelines"` to ensure only target plugin is loaded
121+
Set `CLAUDE_PLUGINS="ui5"` to ensure only target plugin is loaded
122122

123123
### 3. Skill Detection (Heuristic)
124124
Tests detect skill usage by looking for 2+ UI5-specific patterns in response:
@@ -161,7 +161,7 @@ Tests failed NOT because skill didn't respond, but because:
161161

162162
### 4. Environment Configuration Working ✅
163163
- Plugin installation verified before tests
164-
- `CLAUDE_PLUGINS="ui5-guidelines"` set correctly
164+
- `CLAUDE_PLUGINS="ui5"` set correctly
165165
- `MAX_THINKING_TOKENS=0` fixed extended thinking issue
166166
- Tests run in clean environment
167167

@@ -198,7 +198,7 @@ Tests failed NOT because skill didn't respond, but because:
198198
### Environment Variables Set
199199
```typescript
200200
{
201-
CLAUDE_PLUGINS: "ui5-guidelines", // Enable only target plugin
201+
CLAUDE_PLUGINS: "ui5", // Enable only target plugin
202202
MAX_THINKING_TOKENS: "0", // Disable extended thinking (required!)
203203
}
204204
```
@@ -213,7 +213,7 @@ Tests failed NOT because skill didn't respond, but because:
213213

214214
Integration tests successfully validate that:
215215
1. ✅ Plugin infrastructure works correctly
216-
2. ✅ Claude can access and use the ui5-guidelines skill
216+
2. ✅ Claude can access and use the ui5 skill
217217
3. ✅ Skill provides accurate UI5 guidance when triggered
218218
4. ⚠️ Skill triggering is not 100% reliable (40% detection rate)
219219
5. ⚠️ Heuristic detection has limitations

0 commit comments

Comments
 (0)