Skip to content

ui5-best-practices-opa5 skill scope #74

@heimwege

Description

@heimwege

What is the issue and how can we reproduce it?

The skill does not scope the guidance to a specific app type. Nevertheless it seems to be written from a freestyle UI5 perspective. This can lead to recommendations that are wrong in case of e.g. Fiori Elements apps.
A short note could help:

Note: This configuration guide applies to freestyle UI5 OPA5 tests. If you are using SAP Fiori Elements with `sap.fe.test.JourneyRunner`, the setup differs. See the `sap.fe.test` documentation (do we have a good link? Or even better an FE specific skill to reference?) for the correct setup.

This way an AI reading the skill knows upfront whether the guidance applies to the project it's working on, rather than blindly applying freestyle patterns to an FE app.

The skill also currently assumes a classic manual setup and gives no indication that fiori-tools-preview (or similar tooling) can serve the entry point virtually. An AI following the skill literally would either flag the missing opaTests.qunit.js as an error or try to create one unnecessarily.

suggestion:

Note: If you are using `fiori-tools-preview` or similar tooling, the entry point file (`opaTests.qunit.js`) may be served virtually and does not need to exist on disk.

Expected behavior:

Either skip FE opa5 tests or give correct recommendations

Confirmation

  • I've searched the existing issues and reviewed the relevant documentation. I also consulted the documentation at UI5/plugins-coding-agents.
  • I am not disclosing any internal or sensitive information.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions