Skip to content

Commit b2b0256

Browse files
committed
fix: Cast ResourceBundle#getText as string
1 parent f873de2 commit b2b0256

67 files changed

Lines changed: 111 additions & 110 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/walkthrough/steps/08/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export default class AppController extends Controller {
8888
// read msg from i18n model
8989
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
9090
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
91-
const msg = resourceBundle.getText("helloMsg", [recipient]);
91+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
9292
// show message
9393
MessageToast.show(msg);
9494
}
@@ -121,7 +121,7 @@ sap.ui.define(["sap/m/MessageToast", "sap/ui/core/mvc/Controller", "sap/ui/model
121121
// read msg from i18n model
122122
const recipient = this.getView()?.getModel()?.getProperty("/recipient/name");
123123
const resourceBundle = this.getView()?.getModel("i18n")?.getResourceBundle();
124-
const msg = resourceBundle.getText("helloMsg", [recipient]);
124+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
125125
// show message
126126
MessageToast.show(msg);
127127
}

packages/walkthrough/steps/08/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default class AppController extends Controller {
3030
// read msg from i18n model
3131
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
3232
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
33-
const msg = resourceBundle.getText("helloMsg", [recipient]);
33+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
3434
// show message
3535
MessageToast.show(msg);
3636
}

packages/walkthrough/steps/09/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export default class AppController extends Controller {
158158
// read msg from i18n model
159159
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
160160
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
161-
const msg = resourceBundle.getText("helloMsg", [recipient]);
161+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
162162
// show message
163163
MessageToast.show(msg);
164164
}

packages/walkthrough/steps/09/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default class AppController extends Controller {
1313
// functions with generic return values require casting
1414
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
1515
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
16-
const msg = resourceBundle.getText("helloMsg", [recipient]);
16+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
1717
// show message
1818
MessageToast.show(msg);
1919
}

packages/walkthrough/steps/10/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class AppController extends Controller {
1212
// read msg from i18n model
1313
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
1414
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
15-
const msg = resourceBundle.getText("helloMsg", [recipient]);
15+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
1616
// show message
1717
MessageToast.show(msg);
1818
}

packages/walkthrough/steps/11/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class AppController extends Controller {
1212
// read msg from i18n model
1313
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
1414
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
15-
const msg = resourceBundle.getText("helloMsg", [recipient]);
15+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
1616
// show message
1717
MessageToast.show(msg);
1818
}

packages/walkthrough/steps/12/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class AppController extends Controller {
1212
// read msg from i18n model
1313
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
1414
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
15-
const msg = resourceBundle.getText("helloMsg", [recipient]);
15+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
1616
// show message
1717
MessageToast.show(msg);
1818
}

packages/walkthrough/steps/13/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class AppController extends Controller {
1212
// read msg from i18n model
1313
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
1414
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
15-
const msg = resourceBundle.getText("helloMsg", [recipient]);
15+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
1616
// show message
1717
MessageToast.show(msg);
1818
}

packages/walkthrough/steps/14/webapp/controller/App.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class AppController extends Controller {
1212
// read msg from i18n model
1313
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
1414
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
15-
const msg = resourceBundle.getText("helloMsg", [recipient]);
15+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
1616
// show message
1717
MessageToast.show(msg);
1818
}

packages/walkthrough/steps/15/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export default class HelloPanel extends Controller {
5353
// functions with generic return values require casting
5454
const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle;
5555
const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name");
56-
const msg = resourceBundle.getText("helloMsg", [recipient]);
56+
const msg = resourceBundle.getText("helloMsg", [recipient]) as string;
5757
// show message
5858
MessageToast.show(msg);
5959
}

0 commit comments

Comments
 (0)