Add xmlns:core to XML example in README#253
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the missing sap.ui.core XML namespace prefix (core) to the Step 34 walkthrough README’s InvoiceList.view.xml example so the snippet can validly use core UI5 features (notably the existing core:require usage later in the example).
Changes:
- Add
xmlns:core="sap.ui.core"to the<mvc:View>XML snippet in Step 34 documentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Good catch! Thanks a lot @anitamalina |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small update to the XML view file by adding the
sap.ui.corenamespace ascore. This change ensures that core UI5 controls and features can be referenced in the view.xmlns:core="sap.ui.core"namespace declaration to the XML view to enable usage of core UI5 controls.