Skip to content

Commit 754050a

Browse files
Lukas742Lukas742
authored
feat(AnalyticalTable): improve accessibility (#1189)
1 parent e967b89 commit 754050a

3 files changed

Lines changed: 30 additions & 30 deletions

File tree

‎packages/main/src/components/AnalyticalTable/AnalyticalTable.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -872,12 +872,12 @@ describe('AnalyticalTable', () => {
872872
/>
873873
);
874874

875-
const firstRow = getAllByRole('row')[0];
876-
fireEvent.click(firstRow);
875+
const firstBodyRow = getAllByRole('row')[1];
876+
fireEvent.click(firstBodyRow);
877877

878878
expect(callback).toBeCalled();
879879

880-
const selectionColumn = firstRow.querySelector('[data-name="internal_selection_column"]');
880+
const selectionColumn = firstBodyRow.querySelector('[data-name="internal_selection_column"]');
881881
fireEvent.click(selectionColumn);
882882
expect(callback).toBeCalledTimes(1);
883883

‎packages/main/src/components/AnalyticalTable/ColumnHeader/ColumnHeaderContainer.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export const ColumnHeaderContainer = forwardRef((props: ColumnHeaderContainerPro
8383
const classes = useStyles();
8484

8585
return (
86-
<div {...headerProps} role="rowgroup" style={{ width: `${columnVirtualizer.totalSize}px` }} ref={ref}>
86+
<div {...headerProps} style={{ width: `${columnVirtualizer.totalSize}px` }} ref={ref}>
8787
{columnVirtualizer.virtualItems.map((virtualColumn: VirtualItem) => {
8888
const column = headerGroup.headers[virtualColumn.index];
8989
if (!column) {

‎packages/main/src/components/AnalyticalTable/__snapshots__/AnalyticalTable.test.tsx.snap‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ exports[`AnalyticalTable Alternate Row Color 1`] = `
3030
/>
3131
<div
3232
class="AnalyticalTable-tableHeaderRow"
33-
role="rowgroup"
33+
role="row"
3434
style="width: 600px;"
3535
>
3636
<div
@@ -448,7 +448,7 @@ exports[`AnalyticalTable Loading - Loader 1`] = `
448448
/>
449449
<div
450450
class="AnalyticalTable-tableHeaderRow"
451-
role="rowgroup"
451+
role="row"
452452
style="width: 600px;"
453453
>
454454
<div
@@ -866,7 +866,7 @@ exports[`AnalyticalTable Loading - Placeholder 1`] = `
866866
/>
867867
<div
868868
class="AnalyticalTable-tableHeaderRow"
869-
role="rowgroup"
869+
role="row"
870870
style="width: 600px;"
871871
>
872872
<div
@@ -1269,7 +1269,7 @@ exports[`AnalyticalTable RTL: navigation indicator column 1`] = `
12691269
/>
12701270
<div
12711271
class="AnalyticalTable-tableHeaderRow-0-2-2"
1272-
role="rowgroup"
1272+
role="row"
12731273
style="width: 600px;"
12741274
>
12751275
<div
@@ -1626,7 +1626,7 @@ exports[`AnalyticalTable RTL: pop-in columns: w/ pop-ins & hidden column 1`] = `
16261626
/>
16271627
<div
16281628
class="AnalyticalTable-tableHeaderRow-0-2-2"
1629-
role="rowgroup"
1629+
role="row"
16301630
style="width: 600px;"
16311631
>
16321632
<div
@@ -1968,7 +1968,7 @@ exports[`AnalyticalTable RTL: pop-in columns: w/ pop-ins 1`] = `
19681968
/>
19691969
<div
19701970
class="AnalyticalTable-tableHeaderRow-0-2-2"
1971-
role="rowgroup"
1971+
role="row"
19721972
style="width: 800px;"
19731973
>
19741974
<div
@@ -2403,7 +2403,7 @@ exports[`AnalyticalTable RTL: test drag and drop of a draggable column 1`] = `
24032403
/>
24042404
<div
24052405
class="AnalyticalTable-tableHeaderRow-0-2-2"
2406-
role="rowgroup"
2406+
role="row"
24072407
style="width: 600px;"
24082408
>
24092409
<div
@@ -2825,7 +2825,7 @@ exports[`AnalyticalTable RTL: with highlight row 1`] = `
28252825
/>
28262826
<div
28272827
class="AnalyticalTable-tableHeaderRow-0-2-2"
2828-
role="rowgroup"
2828+
role="row"
28292829
style="width: 653px;"
28302830
>
28312831
<div
@@ -3231,7 +3231,7 @@ exports[`AnalyticalTable RTL: with initial column order 1`] = `
32313231
/>
32323232
<div
32333233
class="AnalyticalTable-tableHeaderRow-0-2-2"
3234-
role="rowgroup"
3234+
role="row"
32353235
style="width: 600px;"
32363236
>
32373237
<div
@@ -3650,7 +3650,7 @@ exports[`AnalyticalTable Tree Table 1`] = `
36503650
/>
36513651
<div
36523652
class="AnalyticalTable-tableHeaderRow"
3653-
role="rowgroup"
3653+
role="row"
36543654
style="width: 647px;"
36553655
>
36563656
<div
@@ -4166,7 +4166,7 @@ exports[`AnalyticalTable custom row height 1`] = `
41664166
/>
41674167
<div
41684168
class="AnalyticalTable-tableHeaderRow"
4169-
role="rowgroup"
4169+
role="row"
41704170
style="width: 600px;"
41714171
>
41724172
<div
@@ -4574,7 +4574,7 @@ exports[`AnalyticalTable highlight row with custom row key 1`] = `
45744574
/>
45754575
<div
45764576
class="AnalyticalTable-tableHeaderRow"
4577-
role="rowgroup"
4577+
role="row"
45784578
style="width: 647px;"
45794579
>
45804580
<div
@@ -5052,7 +5052,7 @@ exports[`AnalyticalTable navigation indicator column 1`] = `
50525052
/>
50535053
<div
50545054
class="AnalyticalTable-tableHeaderRow"
5055-
role="rowgroup"
5055+
role="row"
50565056
style="width: 600px;"
50575057
>
50585058
<div
@@ -5405,7 +5405,7 @@ exports[`AnalyticalTable plugin hook: useRowDisableSelection 1`] = `
54055405
/>
54065406
<div
54075407
class="AnalyticalTable-tableHeaderRow"
5408-
role="rowgroup"
5408+
role="row"
54095409
style="width: 600px;"
54105410
>
54115411
<div
@@ -5763,7 +5763,7 @@ exports[`AnalyticalTable pop-in columns: w/ pop-ins & hidden column 1`] = `
57635763
/>
57645764
<div
57655765
class="AnalyticalTable-tableHeaderRow"
5766-
role="rowgroup"
5766+
role="row"
57675767
style="width: 600px;"
57685768
>
57695769
<div
@@ -6101,7 +6101,7 @@ exports[`AnalyticalTable pop-in columns: w/ pop-ins 1`] = `
61016101
/>
61026102
<div
61036103
class="AnalyticalTable-tableHeaderRow"
6104-
role="rowgroup"
6104+
role="row"
61056105
style="width: 800px;"
61066106
>
61076107
<div
@@ -6522,7 +6522,7 @@ exports[`AnalyticalTable render rows 1`] = `
65226522
/>
65236523
<div
65246524
class="AnalyticalTable-tableHeaderRow"
6525-
role="rowgroup"
6525+
role="row"
65266526
style="width: 600px;"
65276527
>
65286528
<div
@@ -6908,7 +6908,7 @@ exports[`AnalyticalTable render rows 2`] = `
69086908
/>
69096909
<div
69106910
class="AnalyticalTable-tableHeaderRow"
6911-
role="rowgroup"
6911+
role="row"
69126912
style="width: 600px;"
69136913
>
69146914
<div
@@ -7274,7 +7274,7 @@ exports[`AnalyticalTable render rows 3`] = `
72747274
/>
72757275
<div
72767276
class="AnalyticalTable-tableHeaderRow"
7277-
role="rowgroup"
7277+
role="row"
72787278
style="width: 600px;"
72797279
>
72807280
<div
@@ -7640,7 +7640,7 @@ exports[`AnalyticalTable render subcomponents 1`] = `
76407640
/>
76417641
<div
76427642
class="AnalyticalTable-tableHeaderRow"
7643-
role="rowgroup"
7643+
role="row"
76447644
style="width: 600px;"
76457645
>
76467646
<div
@@ -8114,7 +8114,7 @@ exports[`AnalyticalTable render without data 1`] = `
81148114
/>
81158115
<div
81168116
class="AnalyticalTable-tableHeaderRow"
8117-
role="rowgroup"
8117+
role="row"
81188118
style="width: 600px;"
81198119
>
81208120
<div
@@ -8288,7 +8288,7 @@ exports[`AnalyticalTable resize vertically 1`] = `
82888288
/>
82898289
<div
82908290
class="AnalyticalTable-tableHeaderRow"
8291-
role="rowgroup"
8291+
role="row"
82928292
style="width: 600px;"
82938293
>
82948294
<div
@@ -10231,7 +10231,7 @@ exports[`AnalyticalTable test drag and drop of a draggable column 1`] = `
1023110231
/>
1023210232
<div
1023310233
class="AnalyticalTable-tableHeaderRow"
10234-
role="rowgroup"
10234+
role="row"
1023510235
style="width: 600px;"
1023610236
>
1023710237
<div
@@ -10649,7 +10649,7 @@ exports[`AnalyticalTable with highlight row 1`] = `
1064910649
/>
1065010650
<div
1065110651
class="AnalyticalTable-tableHeaderRow"
10652-
role="rowgroup"
10652+
role="row"
1065310653
style="width: 653px;"
1065410654
>
1065510655
<div
@@ -11051,7 +11051,7 @@ exports[`AnalyticalTable with initial column order 1`] = `
1105111051
/>
1105211052
<div
1105311053
class="AnalyticalTable-tableHeaderRow"
11054-
role="rowgroup"
11054+
role="row"
1105511055
style="width: 600px;"
1105611056
>
1105711057
<div
@@ -11469,7 +11469,7 @@ exports[`AnalyticalTable without selection Column 1`] = `
1146911469
/>
1147011470
<div
1147111471
class="AnalyticalTable-tableHeaderRow"
11472-
role="rowgroup"
11472+
role="row"
1147311473
style="width: 600px;"
1147411474
>
1147511475
<div

0 commit comments

Comments
 (0)