Skip to content

Commit 8d14a4d

Browse files
refactor(base): resolve dependency cycle in internal utils (#8380)
1 parent 32dd0b8 commit 8d14a4d

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

packages/base/src/internal/utils/addCustomCSSWithScoping.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { attachBoot } from '@ui5/webcomponents-base/dist/Boot.js';
22
import { addCustomCSS } from '@ui5/webcomponents-base/dist/Theming.js';
3-
import { getUi5TagWithSuffix } from './index.js';
3+
import { getUi5TagWithSuffix } from './getUi5TagWithSuffix.js';
44

55
/**
66
* ⚠️ __INTERNAL__ use only! This function is not part of the public API.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import { getEffectiveScopingSuffixForTag } from '@ui5/webcomponents-base/dist/CustomElementsScope.js';
2+
3+
/**
4+
* ⚠️ __INTERNAL__ use only! This function is not part of the public API.
5+
*/
6+
export function getUi5TagWithSuffix(baseTagName: string) {
7+
const tagNameSuffix: string | undefined = getEffectiveScopingSuffixForTag(baseTagName);
8+
return tagNameSuffix ? `${baseTagName}-${tagNameSuffix}` : baseTagName;
9+
}

packages/base/src/internal/utils/index.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { getEffectiveScopingSuffixForTag } from '@ui5/webcomponents-base/dist/CustomElementsScope.js';
1+
export { getUi5TagWithSuffix } from './getUi5TagWithSuffix.js';
22

33
/**
44
* ⚠️ __INTERNAL__ use only! This function is not part of the public API.
@@ -56,14 +56,6 @@ export const enrichEventWithDetails = <
5656
return event as EnrichedEventType<Event, Detail>;
5757
};
5858

59-
/**
60-
* ⚠️ __INTERNAL__ use only! This function is not part of the public API.
61-
*/
62-
export function getUi5TagWithSuffix(baseTagName: string) {
63-
const tagNameSuffix: string | undefined = getEffectiveScopingSuffixForTag(baseTagName);
64-
return tagNameSuffix ? `${baseTagName}-${tagNameSuffix}` : baseTagName;
65-
}
66-
6759
export { debounce } from './debounce.js';
6860
export { throttle } from './throttle.js';
6961
export { addCustomCSSWithScoping } from './addCustomCSSWithScoping.js';

0 commit comments

Comments
 (0)