Skip to content

Commit d75b06f

Browse files
committed
wip: lint conf
1 parent 42b4c95 commit d75b06f

34 files changed

Lines changed: 262 additions & 216 deletions

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# Created by .ignore support plugin (hsz.mobi)
21
node_modules
32
*.iml
43
yarn-error.log

eslint.config.mjs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,12 @@ const config = tseslint.config(
9696
'import/order': [
9797
'error',
9898
{
99-
groups: ['builtin', 'external', 'parent', 'sibling', 'index'],
100-
pathGroups: [
101-
{
102-
pattern: '@ui5/webcomponents-react**',
103-
group: 'internal',
104-
position: 'after',
105-
},
106-
],
107-
alphabetize: { order: 'asc' },
99+
'newlines-between': 'never',
100+
101+
alphabetize: {
102+
order: 'asc',
103+
caseInsensitive: true,
104+
},
108105
},
109106
],
110107

examples/vite-ts/eslint.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import tseslint from 'typescript-eslint';
77
export default tseslint.config(
88
{ ignores: ['dist'] },
99
{
10-
extends: [js.configs.recommended, ...tseslint.configs.recommended, reactHooks.configs.flat.recommended, ],
10+
extends: [js.configs.recommended, ...tseslint.configs.recommended],
1111
files: ['**/*.{ts,tsx}'],
1212
languageOptions: {
1313
ecmaVersion: 2020,

packages/base/src/internal/hooks/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useCurrentTheme } from './useCurrentTheme.js';
2-
import { useIsRTL } from './useIsRTL.js';
32
import { useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect.js';
3+
import { useIsRTL } from './useIsRTL.js';
44
import { useStylesheet } from './useStylesheet.js';
55
import { useSyncRef } from './useSyncRef.js';
66

packages/base/src/internal/hooks/useCurrentTheme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use client';
22

3-
import { attachThemeLoaded, detachThemeLoaded } from '@ui5/webcomponents-base/dist/Theming.js';
43
import { getTheme } from '@ui5/webcomponents-base/dist/config/Theme.js';
4+
import { attachThemeLoaded, detachThemeLoaded } from '@ui5/webcomponents-base/dist/Theming.js';
55
import { useEffect, useState } from 'react';
66

77
export function useCurrentTheme(): string {

packages/charts/src/components/BarChart/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ import type { IChartDimension } from '../../interfaces/IChartDimension.js';
3232
import type { IChartMeasure } from '../../interfaces/IChartMeasure.js';
3333
import { ChartContainer } from '../../internal/ChartContainer.js';
3434
import { ChartDataLabel } from '../../internal/ChartDataLabel.js';
35+
import { defaultFormatter } from '../../internal/defaults.js';
36+
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
3537
import { getCellColors, resolvePrimaryAndSecondaryMeasures } from '../../internal/Utils.js';
3638
import { XAxisTicks } from '../../internal/XAxisTicks.js';
3739
import { YAxisTicks } from '../../internal/YAxisTicks.js';
38-
import { defaultFormatter } from '../../internal/defaults.js';
39-
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
4040
import { BarChartPlaceholder } from './Placeholder.js';
4141

4242
const dimensionDefaults = {

packages/charts/src/components/BulletChart/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ import type { IChartDimension } from '../../interfaces/IChartDimension.js';
2929
import type { IChartMeasure } from '../../interfaces/IChartMeasure.js';
3030
import { ChartContainer } from '../../internal/ChartContainer.js';
3131
import { ChartDataLabel } from '../../internal/ChartDataLabel.js';
32+
import { defaultFormatter } from '../../internal/defaults.js';
33+
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
3234
import { getCellColors, resolvePrimaryAndSecondaryMeasures } from '../../internal/Utils.js';
3335
import { XAxisTicks } from '../../internal/XAxisTicks.js';
3436
import { YAxisTicks } from '../../internal/YAxisTicks.js';
35-
import { defaultFormatter } from '../../internal/defaults.js';
36-
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
3737
import { ComparisonLine } from './ComparisonLine.js';
3838
import { BulletChartPlaceholder } from './Placeholder.js';
3939

packages/charts/src/components/ColumnChart/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ import type { IChartDimension } from '../../interfaces/IChartDimension.js';
3232
import type { IChartMeasure } from '../../interfaces/IChartMeasure.js';
3333
import { ChartContainer } from '../../internal/ChartContainer.js';
3434
import { ChartDataLabel } from '../../internal/ChartDataLabel.js';
35+
import { defaultFormatter } from '../../internal/defaults.js';
36+
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
3537
import { getCellColors, resolvePrimaryAndSecondaryMeasures } from '../../internal/Utils.js';
3638
import { XAxisTicks } from '../../internal/XAxisTicks.js';
3739
import { YAxisTicks } from '../../internal/YAxisTicks.js';
38-
import { defaultFormatter } from '../../internal/defaults.js';
39-
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
4040
import { ColumnChartPlaceholder } from './Placeholder.js';
4141

4242
interface MeasureConfig extends IChartMeasure {

packages/charts/src/components/ComposedChart/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ import type { IChartDimension } from '../../interfaces/IChartDimension.js';
3333
import type { IChartMeasure } from '../../interfaces/IChartMeasure.js';
3434
import { ChartContainer } from '../../internal/ChartContainer.js';
3535
import { ChartDataLabel } from '../../internal/ChartDataLabel.js';
36+
import { defaultFormatter } from '../../internal/defaults.js';
37+
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
3638
import { getCellColors, resolvePrimaryAndSecondaryMeasures } from '../../internal/Utils.js';
3739
import { XAxisTicks } from '../../internal/XAxisTicks.js';
3840
import { YAxisTicks } from '../../internal/YAxisTicks.js';
39-
import { defaultFormatter } from '../../internal/defaults.js';
40-
import { brushProps, tickLineConfig, tooltipContentStyle, tooltipFillOpacity } from '../../internal/staticProps.js';
4141
import { ComposedChartPlaceholder } from './Placeholder.js';
4242

4343
const dimensionDefaults = {

packages/charts/src/components/LineChart/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ import type { IChartDimension } from '../../interfaces/IChartDimension.js';
2626
import type { IChartMeasure } from '../../interfaces/IChartMeasure.js';
2727
import { ChartContainer } from '../../internal/ChartContainer.js';
2828
import { ChartDataLabel } from '../../internal/ChartDataLabel.js';
29-
import { resolvePrimaryAndSecondaryMeasures } from '../../internal/Utils.js';
30-
import { XAxisTicks } from '../../internal/XAxisTicks.js';
31-
import { YAxisTicks } from '../../internal/YAxisTicks.js';
3229
import { defaultFormatter } from '../../internal/defaults.js';
3330
import {
3431
brushProps,
@@ -37,6 +34,9 @@ import {
3734
tooltipFillOpacity,
3835
xAxisPadding,
3936
} from '../../internal/staticProps.js';
37+
import { resolvePrimaryAndSecondaryMeasures } from '../../internal/Utils.js';
38+
import { XAxisTicks } from '../../internal/XAxisTicks.js';
39+
import { YAxisTicks } from '../../internal/YAxisTicks.js';
4040
import { LineChartPlaceholder } from './Placeholder.js';
4141

4242
interface MeasureConfig extends IChartMeasure {

0 commit comments

Comments
 (0)