Skip to content

fix(Toolbar - compat): support React version >= 19.2 & StrictMode #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 3 commits into from
Jan 7, 2026
Merged

fix(Toolbar - compat): support React version >= 19.2 & StrictMode #8073

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
196dec8
fix(Toolbar - compat): support React version >= 19.2 & StrictMode
Lukas742 Jan 7, 2026
869f5fd
Merge branch 'main' into fix/compat-toolbar-overflow
Lukas742 Jan 7, 2026
c856c0c
safeguard meta data assignment
Lukas742 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/compat/src/components/Toolbar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ const Toolbar = forwardRef<HTMLDivElement, ToolbarPropTypes>((props, ref) => {
}
return (
<div
ref={itemRef}
ref={(node) => {
controlMetaData.current[index].ref.current = node;
}}
key={index}
className={classNames.childContainer}
data-component-name="ToolbarChildContainer"
Expand Down
17 changes: 9 additions & 8 deletions packages/main/src/components/ObjectPageTitle/ObjectPageTitle.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@

.title {
flex-shrink: 1;
min-width: 3rem;
overflow-x: hidden;
font-family: var(--sapObjectHeader_Title_FontFamily);
color: var(--sapObjectHeader_Title_TextColor);
Expand Down Expand Up @@ -123,20 +122,22 @@
justify-content: flex-end;
align-self: flex-start;

/*ToDo: remove after legacy toolbar support isn't required anymore*/
&:has([data-in-object-page-title]) {
min-width: 2.125rem;
}
> [data-component-name='Toolbar']:not(:first-child):last-child {
width: unset;
flex-shrink: 0;
}

> [ui5-toolbar] {
padding: 0;
border: none;
}

> [ui5-toolbar]:not(:first-child):last-child {
flex: 0 1;
}

> [data-component-name='Toolbar']:not(:first-child):last-child {
width: unset;
flex-shrink: 0;
}

> [ui5-toolbar]:only-child {
flex-grow: 1;
flex-shrink: 0;
Expand Down
Loading