fix(ObjectPage): re-expand header on tab switch in IconTabBar mode#8817
Open
DougDK wants to merge 1 commit into
Open
fix(ObjectPage): re-expand header on tab switch in IconTabBar mode#8817DougDK wants to merge 1 commit into
DougDK wants to merge 1 commit into
Conversation
In IconTabBar mode, switching tabs while the header was collapsed by
scrolling left the header permanently stuck — scrollTop was reset to 0
but headerCollapsed remained true with no scroll room to trigger
re-expansion.
Reset headerCollapsedInternal to false on tab switch so the header
expands naturally alongside scrollTo({ top: 0 }). The existing
scrollTimeout guard in useObserveHeights already prevents the
programmatic scroll from immediately re-collapsing it.
Also removes the redundant scrollTimeout clause from the spacer height
condition, which was suppressing scroll room during the tab switch
window.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist
Problem
In
IconTabBarmode, if the user scrolled down far enough to collapse the header and then switched tabs, the header could not be re-expanded. AfterscrollTo({ top: 0 }),scrollTopwas0andheaderCollapsedwas stilltrue, leaving the user with no way to scroll further up to trigger re-expansion.Solution
Reset
headerCollapsedInternaltofalseon tab switch so the header expands alongsidescrollTo({ top: 0 }). The existingscrollTimeoutguard inuseObserveHeightsalready prevents the programmatic scroll from immediately re-collapsing it.Also removes the redundant
scrollTimeoutclause from the spacer height condition introduced in #8582, which was suppressing scroll room during the tab switch window and had the same root problem.Fixes #8803