Skip to content

Commit 0d64ca0

Browse files
committed
chore: remove 'inherit' from styles
1 parent e862bff commit 0d64ca0

3 files changed

Lines changed: 1 addition & 30 deletions

File tree

packages/main/cypress/specs/Popover.cy.tsx

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,8 +1911,6 @@ describe("Min Width via CSS", () => {
19111911
cy.get("[ui5-popover]").invoke("prop", "open", true);
19121912

19131913
cy.get("[ui5-popover]")
1914-
.shadow()
1915-
.find(".ui5-popup-root")
19161914
.should("have.css", "min-width", "300px");
19171915
});
19181916

@@ -1951,8 +1949,6 @@ describe("Min Width via CSS", () => {
19511949
cy.get("[ui5-popover]").invoke("prop", "open", true);
19521950

19531951
cy.get("[ui5-popover]")
1954-
.shadow()
1955-
.find(".ui5-popup-root")
19561952
.should("have.css", "min-width", "400px");
19571953

19581954
cy.get("[ui5-popover]")
@@ -1973,25 +1969,4 @@ describe("Min Width via CSS", () => {
19731969
expect(currentWidth).to.be.at.least(400);
19741970
});
19751971
});
1976-
1977-
it("should accept different CSS units", () => {
1978-
cy.mount(
1979-
<>
1980-
<Button id="btnRem">Rem Units</Button>
1981-
<Popover id="popRem" opener="btnRem" style={{ minWidth: "20rem" }}>
1982-
<div>Min width in rem</div>
1983-
</Popover>
1984-
<Button id="btnVw" style={{ marginLeft: "20px" }}>Vw Units</Button>
1985-
<Popover id="popVw" opener="btnVw" style={{ minWidth: "30vw" }}>
1986-
<div>Min width in vw</div>
1987-
</Popover>
1988-
</>
1989-
);
1990-
1991-
cy.get("#popRem").invoke("prop", "open", true);
1992-
cy.get("#popRem")
1993-
.shadow()
1994-
.find(".ui5-popup-root")
1995-
.should("have.css", "min-width", "320px");
1996-
});
19971972
});

packages/main/src/PopoverResize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ class PopoverResize {
240240
minHeight,
241241
} = window.getComputedStyle(this._popover);
242242

243-
const domRefComputedStyle = window.getComputedStyle(this._popover._getRealDomRef!());
243+
const domRefComputedStyle = window.getComputedStyle(this._popover);
244244

245245
this._initialClientX = e.clientX;
246246
this._initialClientY = e.clientY;

packages/main/src/themes/Popover.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@
6060
display: none;
6161
}
6262

63-
.ui5-popover-root {
64-
min-width: inherit;
65-
}
66-
6763
.ui5-popover-arrow {
6864
pointer-events: none;
6965
display: block;

0 commit comments

Comments
 (0)