Skip to content

Commit 14c4218

Browse files
authored
fix(ui5-shellbar): correct icon color in overflow popover (#13517)
Problem: - Icons in the overflow popover were retaining --sapShell_TextColor from the shell header, causing them to appear in the wrong color against the popover's light background. Solution: - Set the button color to --sapList_TextColor inside the overflow popover, consistent with the existing [ui5-li]::part(icon) rule and aligned with the VD spec requirement that overflow icons match the list text color. JIRA: BGSOFUIPIRIN-7069
1 parent 4ea1e2a commit 14c4218

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

packages/fiori/src/themes/ShellBarItem.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
margin: var(--_ui5-shellbar-badge-margin, -0.5rem);
2424
}
2525

26+
[ui5-li]::part(icon) {
27+
color: var(--sapList_TextColor);
28+
}
29+
2630
[ui5-li]:after {
2731
position: relative;
2832
width: fit-content;

packages/fiori/src/themes/ShellBarPopover.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
color: var(--sapList_TextColor);
88
}
99

10+
.ui5-shellbar-overflow-popover ::slotted([ui5-toggle-button]),
11+
.ui5-shellbar-overflow-popover ::slotted([ui5-button]) {
12+
color: var(--sapList_TextColor);
13+
}
14+
1015
.ui5-shellbar-overflow-popover [ui5-li]::part(title) {
1116
font-size: var(--sapFontSize);
1217
}

0 commit comments

Comments
 (0)