Commit 1bfa9ee
authored
fix(ui5-card): remove max-height constraint from subtitle to prevent text clipping for tall-character languages (#13413)
Description
The ui5-card-header subtitle text was being visually cut off for languages
that require more vertical space per line, such as Hindi. This was caused by
a hardcoded max-height: 2.1rem on the subtitle element, which is calculated
based on Latin character height and does not accommodate the taller glyphs and
diacritics found in other scripts.
The -webkit-line-clamp: 2 rule already enforces the two-line limit correctly
for all languages, making the max-height constraint redundant and harmful.
Changes
Removed max-height: 2.1rem from .ui5-card-header-subtitle in CardHeader.css
Added a Cypress test to verify no max-height is applied to the subtitle
How to Test
Open a ui5-card-header with a subtitleText containing Hindi text, e.g.:
आपके डिवाइस या फ़ाइल सर्वर से फ़ाइल (xlsx, csv, txt, आदि)
Verify the subtitle text is fully visible and not clipped at the bottom.
Before:
Screenshot 2026-04-20 at 10 14 36
After:
Screenshot 2026-04-20 at 10 14 24
Fixes #133791 parent f0e62ec commit 1bfa9ee
2 files changed
Lines changed: 30 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
338 | 368 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | 139 | | |
141 | 140 | | |
142 | 141 | | |
| |||
0 commit comments